Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[MRG] User Guide #295
What does this implement/fix? Explain your changes.
Any other comments?
Hello @glemaitre! Thanks for updating the PR.
Comment last updated on August 11, 2017 at 23:05 Hours UTC
@@ Coverage Diff @@ ## master #295 +/- ## ======================================= Coverage 98.33% 98.33% ======================================= Files 66 66 Lines 3848 3848 ======================================= Hits 3784 3784 Misses 64 64
For the moment it is how it looks:
What need to be carefully done is to design an example if we need some images such that we automatically generate them. Then we need cross-referencing to the API doc to the User Guide and ase well from the API doc to the example.
Let me know if you would have some time to put on that.
In general this work is quite good. We can merge in order to enhance the documentation and correct afterwards. Some notes:
I would move the 1.1 and do 0. where we state the problem.
If I land in under-sampling, the example of what I'm trying to understand is under the title of oversampling, so I wont be able to find it. However if in the index there's a 0 - The problem of imbalance. It's more likely that I realize that I might want to read that first.
I didn't fin this (
It is also possible to bootstrap the data when resampling by setting replacement to True.) but I would change it by:
...resampling using bootstrap by setting ... and I would actually not use
it also but