New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] EHN make_imbalance handle multi-class #312

Merged
merged 2 commits into from Aug 3, 2017

Conversation

Projects
None yet
1 participant
@glemaitre
Member

glemaitre commented Aug 3, 2017

Reference Issue

closes #283

What does this implement/fix? Explain your changes.

make_imbalance will support multi-class and will have a uniform API with the sampler.

Any other comments?

@glemaitre glemaitre changed the title from [WIP] EHN make_imbalance handle multi-class to [MRG] EHN make_imbalance handle multi-class Aug 3, 2017

@glemaitre

This comment has been minimized.

Member

glemaitre commented Aug 3, 2017

Appveyor is a bit slower but this should be done.

@massich @chkoar ready for reviews

@codecov

This comment has been minimized.

codecov bot commented Aug 3, 2017

Codecov Report

Merging #312 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #312      +/-   ##
==========================================
- Coverage   98.33%   98.32%   -0.02%     
==========================================
  Files          68       68              
  Lines        3910     3879      -31     
==========================================
- Hits         3845     3814      -31     
  Misses         65       65
Impacted Files Coverage Δ
...mpling/prototype_selection/random_under_sampler.py 100% <ø> (ø) ⬆️
imblearn/datasets/imbalance.py 100% <100%> (ø) ⬆️
imblearn/utils/tests/test_validation.py 100% <100%> (ø) ⬆️
imblearn/datasets/tests/test_imbalance.py 100% <100%> (ø)
imblearn/base.py 97.67% <100%> (ø) ⬆️
imblearn/utils/validation.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f695fb7...71eb634. Read the comment docs.

@glemaitre

This comment has been minimized.

Member

glemaitre commented Aug 3, 2017

I need this part now so please review and we will fix it later on.

@glemaitre glemaitre merged commit 1e3fdfe into scikit-learn-contrib:master Aug 3, 2017

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 98.33%)
Details
codecov/project Absolute coverage decreased by -0.01% but relative coverage increased by +1.66% compared to f695fb7
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment