New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] EHN: Implementation of BalancedRandomForestClassifier #459

Merged
merged 39 commits into from Sep 6, 2018

Conversation

Projects
None yet
4 participants
@glemaitre
Member

glemaitre commented Aug 26, 2018

closes #456

@pep8speaks

This comment has been minimized.

pep8speaks commented Aug 26, 2018

Hello @glemaitre! Thanks for updating the PR.

Comment last updated on September 06, 2018 at 12:29 Hours UTC
@glemaitre

This comment has been minimized.

Member

glemaitre commented Aug 26, 2018

@chkoar I made a quick implementation of a balanced random forest classifier.
I tried to keep the changes minimal. The issue is that most of the code rely that the base estimators are trees, calling some private functions. Therefore, we cannot easily use pipeline as in the bagging case.

If you could have a look at it. It would be nice to have a second opinion.

@glemaitre

This comment has been minimized.

Member

glemaitre commented Aug 26, 2018

Note that this can work only with the release 0.20 which is the reason for the failing.

@chkoar

This comment has been minimized.

Member

chkoar commented Aug 27, 2018

We don't implement this via Bagging in order to get feature importances out of the box, right?

@glemaitre

This comment has been minimized.

Member

glemaitre commented Aug 27, 2018

@massich

This comment has been minimized.

Contributor

massich commented Aug 28, 2018

There's some issue with the init. I'll check it out

@glemaitre glemaitre changed the title from EHN: Implementation of BalancedRandomForestClassifier to [WIP] EHN: Implementation of BalancedRandomForestClassifier Aug 29, 2018

glemaitre added some commits Sep 4, 2018

@codecov

This comment has been minimized.

codecov bot commented Sep 5, 2018

Codecov Report

Merging #459 into master will increase coverage by <.01%.
The diff coverage is 98.96%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #459      +/-   ##
=========================================
+ Coverage   98.69%   98.7%   +<.01%     
=========================================
  Files          75      77       +2     
  Lines        4538    4720     +182     
=========================================
+ Hits         4479    4659     +180     
- Misses         59      61       +2
Impacted Files Coverage Δ
imblearn/ensemble/_bagging.py 100% <ø> (ø) ⬆️
imblearn/ensemble/tests/test_forest.py 100% <100%> (ø)
imblearn/utils/_validation.py 100% <100%> (ø) ⬆️
imblearn/ensemble/__init__.py 100% <100%> (ø) ⬆️
...ling/_prototype_selection/_random_under_sampler.py 100% <100%> (ø) ⬆️
imblearn/ensemble/_forest.py 98.13% <98.13%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 839df67...a21418b. Read the comment docs.

glemaitre added some commits Sep 5, 2018

@glemaitre glemaitre force-pushed the scikit-learn-contrib:master branch from ff26448 to 839df67 Sep 5, 2018

@glemaitre glemaitre merged commit 4dfd35c into scikit-learn-contrib:master Sep 6, 2018

0 of 4 checks passed

LGTM analysis: Python Fetching git commits
Details
ci/circleci: python3 CircleCI is running your tests
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

glemaitre added a commit that referenced this pull request Sep 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment