New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: refactor and pytest style #470

Merged
merged 5 commits into from Sep 7, 2018

Conversation

Projects
None yet
2 participants
@glemaitre
Member

glemaitre commented Sep 6, 2018

Take over #322 and #380

@pep8speaks

This comment has been minimized.

pep8speaks commented Sep 6, 2018

Hello @glemaitre! Thanks for updating the PR.

Line 23:80: E501 line too long (82 > 79 characters)

Line 9:1: E402 module level import not at top of file
Line 10:1: E402 module level import not at top of file
Line 11:1: E402 module level import not at top of file
Line 13:1: E402 module level import not at top of file
Line 14:1: E402 module level import not at top of file
Line 15:1: E402 module level import not at top of file
Line 16:1: E402 module level import not at top of file
Line 18:1: E402 module level import not at top of file
Line 19:1: E402 module level import not at top of file
Line 40:80: E501 line too long (80 > 79 characters)

Line 188:17: W605 invalid escape sequence '['
Line 188:28: W605 invalid escape sequence ']'
Line 235:80: E501 line too long (87 > 79 characters)
Line 236:80: E501 line too long (85 > 79 characters)
Line 257:1: E302 expected 2 blank lines, found 1

Line 36:35: E231 missing whitespace after ','
Line 54:80: E501 line too long (80 > 79 characters)

Line 20:1: E302 expected 2 blank lines, found 1

Comment last updated on September 07, 2018 at 12:40 Hours UTC
@codecov

This comment has been minimized.

codecov bot commented Sep 7, 2018

Codecov Report

Merging #470 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #470      +/-   ##
=========================================
- Coverage    98.7%   98.7%   -0.01%     
=========================================
  Files          77      77              
  Lines        4720    4697      -23     
=========================================
- Hits         4659    4636      -23     
  Misses         61      61
Impacted Files Coverage Δ
imblearn/combine/tests/test_smote_tomek.py 100% <100%> (ø) ⬆️
imblearn/keras/tests/test_generator.py 100% <100%> (ø) ⬆️
imblearn/datasets/tests/test_imbalance.py 100% <100%> (ø) ⬆️
imblearn/combine/tests/test_smote_enn.py 100% <100%> (ø) ⬆️
imblearn/datasets/tests/test_zenodo.py 88.57% <100%> (-1.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f0a4b2...a6a0935. Read the comment docs.

glemaitre added some commits Sep 7, 2018

@glemaitre glemaitre merged commit eed8d95 into scikit-learn-contrib:master Sep 7, 2018

0 of 4 checks passed

LGTM analysis: Python Fetching git commits
Details
ci/circleci: python3 CircleCI is running your tests
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@glemaitre glemaitre referenced this pull request Sep 7, 2018

Closed

pytest follow up #323

9 of 15 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment