MAINT: deprecate return_indices in favor of attribute sample_indices_

[glemaitre]

return_indices allowed to return an array with the selected samples for a specific sampler. This is actually not use in the usual scikit-learn API. Instead, we created a sample_indices_ attribute instead.

[pep8speaks]

Hello @glemaitre! Thanks for updating the PR.

• In the file imblearn/ensemble/_easy_ensemble.py, following are the PEP8 issues :

Line 94:80: E501 line too long (80 > 79 characters)

• There are no PEP8 issues in the file imblearn/ensemble/_forest.py !

• There are no PEP8 issues in the file imblearn/ensemble/_weight_boosting.py !

• There are no PEP8 issues in the file imblearn/ensemble/tests/test_forest.py !

• There are no PEP8 issues in the file imblearn/keras/_generator.py !

• In the file imblearn/keras/tests/test_generator.py, following are the PEP8 issues :

Line 9:1: E402 module level import not at top of file
Line 10:1: E402 module level import not at top of file
Line 11:1: E402 module level import not at top of file
Line 13:1: E402 module level import not at top of file
Line 14:1: E402 module level import not at top of file
Line 15:1: E402 module level import not at top of file
Line 16:1: E402 module level import not at top of file
Line 18:1: E402 module level import not at top of file
Line 19:1: E402 module level import not at top of file
Line 40:80: E501 line too long (80 > 79 characters)

• There are no PEP8 issues in the file imblearn/over_sampling/_random_over_sampler.py !

• There are no PEP8 issues in the file imblearn/over_sampling/tests/test_random_over_sampler.py !

• There are no PEP8 issues in the file imblearn/tensorflow/_generator.py !

• There are no PEP8 issues in the file imblearn/tests/test_common.py !

• There are no PEP8 issues in the file imblearn/under_sampling/_prototype_selection/_condensed_nearest_neighbour.py !

• There are no PEP8 issues in the file imblearn/under_sampling/_prototype_selection/_edited_nearest_neighbours.py !

• There are no PEP8 issues in the file imblearn/under_sampling/_prototype_selection/_instance_hardness_threshold.py !

• There are no PEP8 issues in the file imblearn/under_sampling/_prototype_selection/_nearmiss.py !

• In the file imblearn/under_sampling/_prototype_selection/_neighbourhood_cleaning_rule.py, following are the PEP8 issues :

Line 203:80: E501 line too long (81 > 79 characters)

• There are no PEP8 issues in the file imblearn/under_sampling/_prototype_selection/_one_sided_selection.py !

• There are no PEP8 issues in the file imblearn/under_sampling/_prototype_selection/_random_under_sampler.py !

• There are no PEP8 issues in the file imblearn/under_sampling/_prototype_selection/_tomek_links.py !

• There are no PEP8 issues in the file imblearn/under_sampling/_prototype_selection/tests/test_allknn.py !

• There are no PEP8 issues in the file imblearn/under_sampling/_prototype_selection/tests/test_condensed_nearest_neighbour.py !

• There are no PEP8 issues in the file imblearn/under_sampling/_prototype_selection/tests/test_edited_nearest_neighbours.py !

• There are no PEP8 issues in the file imblearn/under_sampling/_prototype_selection/tests/test_instance_hardness_threshold.py !

• There are no PEP8 issues in the file imblearn/under_sampling/_prototype_selection/tests/test_nearmiss.py !

• There are no PEP8 issues in the file imblearn/under_sampling/_prototype_selection/tests/test_neighbourhood_cleaning_rule.py !

• There are no PEP8 issues in the file imblearn/under_sampling/_prototype_selection/tests/test_one_sided_selection.py !

• There are no PEP8 issues in the file imblearn/under_sampling/_prototype_selection/tests/test_random_under_sampler.py !

• There are no PEP8 issues in the file imblearn/under_sampling/_prototype_selection/tests/test_repeated_edited_nearest_neighbours.py !

• There are no PEP8 issues in the file imblearn/under_sampling/_prototype_selection/tests/test_tomek_links.py !

• In the file imblearn/utils/estimator_checks.py, following are the PEP8 issues :

Line 168:33: E127 continuation line over-indented for visual indent

Comment last updated on September 13, 2018 at 10:04 Hours UTC