New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: deprecate return_indices in favor of attribute sample_indices_ #474

Merged
merged 2 commits into from Sep 13, 2018

Conversation

Projects
None yet
2 participants
@glemaitre
Member

glemaitre commented Sep 13, 2018

return_indices allowed to return an array with the selected samples for a specific sampler. This is actually not use in the usual scikit-learn API. Instead, we created a sample_indices_ attribute instead.

@pep8speaks

This comment has been minimized.

pep8speaks commented Sep 13, 2018

Hello @glemaitre! Thanks for updating the PR.

Line 94:80: E501 line too long (80 > 79 characters)

Line 9:1: E402 module level import not at top of file
Line 10:1: E402 module level import not at top of file
Line 11:1: E402 module level import not at top of file
Line 13:1: E402 module level import not at top of file
Line 14:1: E402 module level import not at top of file
Line 15:1: E402 module level import not at top of file
Line 16:1: E402 module level import not at top of file
Line 18:1: E402 module level import not at top of file
Line 19:1: E402 module level import not at top of file
Line 40:80: E501 line too long (80 > 79 characters)

Line 203:80: E501 line too long (81 > 79 characters)

Line 168:33: E127 continuation line over-indented for visual indent

Comment last updated on September 13, 2018 at 10:04 Hours UTC

@glemaitre glemaitre merged commit a19d398 into scikit-learn-contrib:master Sep 13, 2018

4 checks passed

LGTM analysis: Python No alert changes
Details
ci/circleci: python3 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment