Fix docstring about sampling strategy for under and oversampling #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #525 +/- ##
=======================================
Coverage 98.86% 98.86%
=======================================
Files 82 82
Lines 5023 5023
=======================================
Hits 4966 4966
Misses 57 57
Continue to review full report at Codecov.
|
|
Thanks for the PR. I pushed a couple of fixes in one of the examples and added what's new entry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #517 and #522
I change the docstring about sampling strategy when it's a float as I mentioned in #517 and taking into consideration the changes proposed by snowparrot in the same issue.