Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docstring about sampling strategy for under and oversampling #525

Merged
merged 4 commits into from Jan 19, 2019

Conversation

@arielrossanigo
Copy link
Contributor

@arielrossanigo arielrossanigo commented Jan 11, 2019

Fixes #517 and #522

I change the docstring about sampling strategy when it's a float as I mentioned in #517 and taking into consideration the changes proposed by snowparrot in the same issue.

@codecov
Copy link

@codecov codecov bot commented Jan 11, 2019

Codecov Report

Merging #525 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #525   +/-   ##
=======================================
  Coverage   98.86%   98.86%           
=======================================
  Files          82       82           
  Lines        5023     5023           
=======================================
  Hits         4966     4966           
  Misses         57       57
Impacted Files Coverage Δ
imblearn/over_sampling/base.py 100% <ø> (ø) ⬆️
imblearn/under_sampling/base.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ba0dbb...cb3988d. Read the comment docs.

@glemaitre glemaitre merged commit ca8729f into scikit-learn-contrib:master Jan 19, 2019
0 of 3 checks passed
@glemaitre
Copy link
Member

@glemaitre glemaitre commented Jan 19, 2019

Thanks for the PR. I pushed a couple of fixes in one of the examples and added what's new entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants