Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Parallelisation for SMOTEENN and SMOTETomek #547

Merged

Conversation

Projects
None yet
4 participants
@Microsheep
Copy link
Contributor

commented Feb 18, 2019

Fixes #541

This Merge Request adds n_jobs parameter for SMOTEENN and SMOTETomek

@pep8speaks

This comment has been minimized.

Copy link

commented Feb 18, 2019

Hello @Microsheep! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on February 19, 2019 at 13:10 Hours UTC

@Microsheep Microsheep force-pushed the Microsheep:parallel_for_combine_methods branch from 6e9dae2 to b1a48a2 Feb 18, 2019

@codecov

This comment has been minimized.

Copy link

commented Feb 18, 2019

Codecov Report

Merging #547 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #547      +/-   ##
==========================================
+ Coverage   98.86%   98.87%   +<.01%     
==========================================
  Files          82       82              
  Lines        5025     5049      +24     
==========================================
+ Hits         4968     4992      +24     
  Misses         57       57
Impacted Files Coverage Δ
imblearn/combine/_smote_tomek.py 100% <100%> (ø) ⬆️
imblearn/combine/_smote_enn.py 100% <100%> (ø) ⬆️
imblearn/combine/tests/test_smote_tomek.py 100% <100%> (ø) ⬆️
imblearn/combine/tests/test_smote_enn.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4559071...aba9470. Read the comment docs.

@glemaitre

This comment has been minimized.

Copy link
Member

commented Feb 18, 2019

Thanks can you add an entry in whats new and a test.

For the test, you can just set n_jobs and check that the underlying enn or smote we have the expected number of jobs.

@Microsheep Microsheep changed the title [MRG] Parallelisation for SMOTENN and SMOTETomek [MRG] Parallelisation for SMOTEENN and SMOTETomek Feb 19, 2019

@Microsheep

This comment has been minimized.

Copy link
Contributor Author

commented Feb 19, 2019

@glemaitre Thanks for the comment, I had finish adding tests and added an entry in whats new.

@glemaitre glemaitre changed the title [MRG] Parallelisation for SMOTEENN and SMOTETomek [MRG+1] Parallelisation for SMOTEENN and SMOTETomek Feb 19, 2019

@glemaitre

This comment has been minimized.

Copy link
Member

commented Feb 19, 2019

LGTM @chkoar could you have a second look at it

@chkoar

This comment has been minimized.

Copy link
Member

commented Feb 19, 2019

@Microsheep in the issue number put the number of your PR. Apart from that it's ok.

@Microsheep

This comment has been minimized.

Copy link
Contributor Author

commented Feb 19, 2019

@chkoar Got it! I had change to use the PR number.

@glemaitre glemaitre merged commit dff4670 into scikit-learn-contrib:master Feb 21, 2019

5 checks passed

LGTM analysis: Python No new or fixed alerts
Details
codecov/patch 100% of diff hit (target 98.86%)
Details
codecov/project 98.87% (+<.01%) compared to 4559071
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@glemaitre

This comment has been minimized.

Copy link
Member

commented Feb 21, 2019

@Microsheep Thanks for the PR!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.