-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG+1] Parallelisation for SMOTEENN and SMOTETomek #547
[MRG+1] Parallelisation for SMOTEENN and SMOTETomek #547
Conversation
Hello @Microsheep! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on February 19, 2019 at 13:10 Hours UTC |
6e9dae2
to
b1a48a2
Compare
Codecov Report
@@ Coverage Diff @@
## master #547 +/- ##
==========================================
+ Coverage 98.86% 98.87% +<.01%
==========================================
Files 82 82
Lines 5025 5049 +24
==========================================
+ Hits 4968 4992 +24
Misses 57 57
Continue to review full report at Codecov.
|
Thanks can you add an entry in whats new and a test. For the test, you can just set n_jobs and check that the underlying enn or smote we have the expected number of jobs. |
@glemaitre Thanks for the comment, I had finish adding tests and added an entry in whats new. |
LGTM @chkoar could you have a second look at it |
@Microsheep in the issue number put the number of your PR. Apart from that it's ok. |
@chkoar Got it! I had change to use the PR number. |
@Microsheep Thanks for the PR!!! |
Fixes #541
This Merge Request adds n_jobs parameter for SMOTEENN and SMOTETomek