Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] MAINT drop python 2 and upgrade scikit-learn 0.21 #576

Merged
merged 13 commits into from Jun 7, 2019

Conversation

Projects
None yet
2 participants
@glemaitre
Copy link
Member

commented Jun 7, 2019

closes #574
closes #570

@glemaitre glemaitre changed the title MAINT drop python 2 and upgrade scikit-learn 0.21 [WIP] MAINT drop python 2 and upgrade scikit-learn 0.21 Jun 7, 2019

@pep8speaks

This comment has been minimized.

Copy link

commented Jun 7, 2019

Hello @glemaitre! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 334:80: E501 line too long (83 > 79 characters)

Line 32:80: E501 line too long (80 > 79 characters)
Line 83:80: E501 line too long (84 > 79 characters)
Line 106:80: E501 line too long (85 > 79 characters)
Line 109:80: E501 line too long (82 > 79 characters)

Comment last updated at 2019-06-07 18:55:59 UTC

glemaitre added some commits Jun 7, 2019

@codecov

This comment has been minimized.

Copy link

commented Jun 7, 2019

Codecov Report

Merging #576 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #576      +/-   ##
==========================================
- Coverage   98.89%   98.85%   -0.04%     
==========================================
  Files          84       84              
  Lines        5154     5151       -3     
==========================================
- Hits         5097     5092       -5     
- Misses         57       59       +2
Impacted Files Coverage Δ
imblearn/utils/tests/test_docstring.py 76.92% <ø> (ø) ⬆️
imblearn/utils/testing.py 100% <ø> (ø) ⬆️
...rototype_selection/_instance_hardness_threshold.py 100% <100%> (ø) ⬆️
...ling/_prototype_selection/_random_under_sampler.py 100% <100%> (ø) ⬆️
imblearn/combine/_smote_tomek.py 100% <100%> (ø) ⬆️
imblearn/ensemble/_easy_ensemble.py 100% <100%> (ø) ⬆️
...rototype_selection/_neighbourhood_cleaning_rule.py 100% <100%> (ø) ⬆️
imblearn/utils/_docstring.py 100% <100%> (ø) ⬆️
...nder_sampling/_prototype_selection/_tomek_links.py 100% <100%> (ø) ⬆️
imblearn/utils/tests/test_deprecation.py 100% <100%> (ø) ⬆️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77cad85...33ea76a. Read the comment docs.

@glemaitre glemaitre changed the title [WIP] MAINT drop python 2 and upgrade scikit-learn 0.21 [MRG] MAINT drop python 2 and upgrade scikit-learn 0.21 Jun 7, 2019

glemaitre added some commits Jun 7, 2019

fix

@glemaitre glemaitre merged commit e12aab3 into scikit-learn-contrib:master Jun 7, 2019

3 of 5 checks passed

LGTM analysis: Python Running analyses for revisions
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
LGTM analysis: JavaScript No code changes detected
Details
ci/circleci: python3 Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.