New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] 👽 Maintenance for imblearn.show_versions()
, fix Travis build
#591
[MRG] 👽 Maintenance for imblearn.show_versions()
, fix Travis build
#591
Conversation
Drop `get_blas_info()` vendored from sklearn Fix unit tests to reflect the fix
Fix `imblearn.utils._show_versions` by shortening a line Fix test case to reflect this change
Codecov Report
@@ Coverage Diff @@
## master #591 +/- ##
==========================================
- Coverage 98.92% 98.92% -0.01%
==========================================
Files 85 85
Lines 5324 5310 -14
==========================================
- Hits 5267 5253 -14
Misses 57 57
Continue to review full report at Codecov.
|
Build is still failing on Travis with: ReadError('file could not be opened successfully') edit: It looks like the error is stemming from edit2: It looks like updating conda resolves this error: - conda install --yes conda=4.6
+ conda config --set always_yes yes --set changeps1 no
+ conda install conda=4.6
+ conda update -q conda I also added a few of the recommendations from the conda + Travis guide, such as printing debug information and setting default values. |
Bump `SKLEARN_VERSION="0.21.3"` in `.travis.yml` Add conda config and debugging options to `install.sh`
imblearn.show_versions()
imblearn.show_versions()
, fix Travis build
@glemaitre, @chkoar Errors with Travis-CI should be resolved now. This should also fix the build failure in #592 |
…w_versions()`, fix Travis build scikit-learn-contrib#591
Thanks |
Summary
get_blas_info()
vendored from sklearnWhat does this implement/fix? Explain your changes.
imblearn/utils/_show_versions
used several utilities from scikit-learn. BLAS/CBLAS were recently dropped andget_blas_info()
was removed.This patch reflects these changes.
Any other comments?
See scikit-learn#14205