Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] 馃懡 Maintenance for `imblearn.show_versions()`, fix Travis build #591

Merged
merged 5 commits into from Sep 5, 2019

Conversation

@hayesall
Copy link
Contributor

hayesall commented Aug 9, 2019

Summary

  • Drop get_blas_info() vendored from sklearn
  • Fix unit tests to reflect the fix

What does this implement/fix? Explain your changes.

imblearn/utils/_show_versions used several utilities from scikit-learn. BLAS/CBLAS were recently dropped and get_blas_info() was removed.

This patch reflects these changes.

Any other comments?

See scikit-learn#14205

Drop `get_blas_info()` vendored from sklearn
Fix unit tests to reflect the fix
@pep8speaks

This comment has been minimized.

Copy link

pep8speaks commented Aug 9, 2019

Hello @hayesall! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 馃嵒

Comment last updated at 2019-08-14 16:30:23 UTC
Fix `imblearn.utils._show_versions` by shortening a line
Fix test case to reflect this change
@codecov

This comment has been minimized.

Copy link

codecov bot commented Aug 14, 2019

Codecov Report

Merging #591 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #591      +/-   ##
==========================================
- Coverage   98.92%   98.92%   -0.01%     
==========================================
  Files          85       85              
  Lines        5324     5310      -14     
==========================================
- Hits         5267     5253      -14     
  Misses         57       57
Impacted Files Coverage 螖
imblearn/utils/_show_versions.py 100% <100%> (酶) 猬嗭笍
imblearn/utils/tests/test_show_versions.py 100% <100%> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update e1be869...eed2e70. Read the comment docs.

@hayesall

This comment has been minimized.

Copy link
Contributor Author

hayesall commented Aug 14, 2019

Build is still failing on Travis with:

ReadError('file could not be opened successfully')

edit:

It looks like the error is stemming from install.sh when creating a new conda environment, but it will take me a bit longer to debug it.

edit2:

It looks like updating conda resolves this error:

- conda install --yes conda=4.6
+ conda config --set always_yes yes --set changeps1 no
+ conda install conda=4.6
+ conda update -q conda

I also added a few of the recommendations from the conda + Travis guide, such as printing debug information and setting default values.

hayesall added 3 commits Aug 14, 2019
Bump `SKLEARN_VERSION="0.21.3"` in `.travis.yml`
Add conda config and debugging options to `install.sh`
@hayesall hayesall changed the title [MRG] 馃懡 Maintenance for `imblearn.show_versions()` [MRG] 馃懡 Maintenance for `imblearn.show_versions()`, fix Travis build Aug 15, 2019
@hayesall

This comment has been minimized.

Copy link
Contributor Author

hayesall commented Aug 15, 2019

@glemaitre, @chkoar Errors with Travis-CI should be resolved now. This should also fix the build failure in #592

EvgeniDubov added a commit to EvgeniDubov/imbalanced-learn that referenced this pull request Aug 15, 2019
@chkoar chkoar merged commit 44ac642 into scikit-learn-contrib:master Sep 5, 2019
4 checks passed
4 checks passed
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No new or fixed alerts
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@chkoar

This comment has been minimized.

Copy link
Member

chkoar commented Sep 5, 2019

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.