Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in specificity_score #614

Merged
merged 2 commits into from Nov 8, 2019

Conversation

@hayesall
Copy link
Contributor

hayesall commented Oct 15, 2019

Summary

Fix typo fn -> fp
Fix typo "false negatives" -> "false positives"
Fix removing empty reference: _[1] ->

Reference Issue

  • Former issue on this topic: #592
  • Fixes #613

What does this implement/fix? Explain your changes.

This fixes the wording in imblearn.metrics._classification.specificity_score(...):

- ... `fn` the number of false negatives. ...
+ ... `fp` the number of false positives. ...

And drops an empty reference:

- ... false positives_[1].
+ ... false positives.

Any other comments?

The latest documentation for specificity score does not seem to currently reflect the recent changes (e.g. #592).

It might be worth checking the sphinx builds on ReadTheDocs, it's possible that they haven't been deploying recently.

hayesall added 2 commits Oct 15, 2019
Fix typo `fn` -> `fp`
Fix typo "false negatives" -> "false positives"
Fix `_[1]` -> `` in imblearn/metrics/_classification.py
@glemaitre glemaitre merged commit 8cc0094 into scikit-learn-contrib:master Nov 8, 2019
1 of 4 checks passed
1 of 4 checks passed
LGTM analysis: JavaScript Install the LGTM.com GitHub App to re-enable automated code review integration
Details
LGTM analysis: Python Install the LGTM.com GitHub App to re-enable automated code review integration
Details
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@glemaitre

This comment has been minimized.

Copy link
Member

glemaitre commented Nov 8, 2019

@hayesall Thanks for the PR

@hayesall hayesall deleted the hayesall:specificity branch Dec 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.