Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT compatibility with scikit-learn 0.22 #617

Merged
merged 37 commits into from Oct 31, 2019

Conversation

@glemaitre
Copy link
Member

glemaitre commented Oct 29, 2019

closes #616

glemaitre added 2 commits Oct 29, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 29, 2019

Codecov Report

Merging #617 into master will decrease coverage by 0.68%.
The diff coverage is 98.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #617      +/-   ##
==========================================
- Coverage   98.92%   98.23%   -0.69%     
==========================================
  Files          85       83       -2     
  Lines        5310     4709     -601     
==========================================
- Hits         5253     4626     -627     
- Misses         57       83      +26
Impacted Files Coverage Δ
imblearn/utils/__init__.py 100% <ø> (ø) ⬆️
imblearn/under_sampling/__init__.py 100% <ø> (ø) ⬆️
...rn/under_sampling/_prototype_selection/__init__.py 100% <ø> (ø) ⬆️
imblearn/metrics/__init__.py 100% <ø> (ø) ⬆️
imblearn/datasets/tests/test_imbalance.py 100% <ø> (ø) ⬆️
imblearn/under_sampling/base.py 100% <100%> (ø) ⬆️
imblearn/over_sampling/tests/test_adasyn.py 100% <100%> (ø) ⬆️
imblearn/utils/tests/test_deprecation.py 100% <100%> (ø) ⬆️
imblearn/over_sampling/tests/test_smote.py 100% <100%> (ø) ⬆️
imblearn/keras/__init__.py 100% <100%> (ø) ⬆️
... and 73 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbe3820...034270f. Read the comment docs.

glemaitre added 9 commits Oct 29, 2019
@glemaitre glemaitre changed the title DOC issue compiling documentation MAINT compatibility with scikit-learn 0.22 Oct 30, 2019
@pep8speaks

This comment has been minimized.

Copy link

pep8speaks commented Oct 31, 2019

Hello @glemaitre! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 47:1: E402 module level import not at top of file

Comment last updated at 2019-10-31 16:18:08 UTC
glemaitre added 9 commits Oct 31, 2019
glemaitre added 6 commits Oct 31, 2019
@lgtm-com

This comment has been minimized.

Copy link

lgtm-com bot commented Oct 31, 2019

This pull request fixes 7 alerts when merging e31c6c6 into bbe3820 - view on LGTM.com

fixed alerts:

  • 7 for Unused import
glemaitre added 3 commits Oct 31, 2019
xxx
@lgtm-com

This comment has been minimized.

Copy link

lgtm-com bot commented Oct 31, 2019

This pull request fixes 7 alerts when merging 3603cdf into bbe3820 - view on LGTM.com

fixed alerts:

  • 7 for Unused import
@glemaitre glemaitre merged commit 7032dcb into scikit-learn-contrib:master Oct 31, 2019
2 of 5 checks passed
2 of 5 checks passed
ci/circleci: python3 CircleCI is running your tests
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python 7 fixed alerts
Details
@lgtm-com

This comment has been minimized.

Copy link

lgtm-com bot commented Oct 31, 2019

This pull request fixes 7 alerts when merging 034270f into bbe3820 - view on LGTM.com

fixed alerts:

  • 7 for Unused import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.