Skip to content

MAINT compatibility with scikit-learn 0.22 - #617

Merged
glemaitre merged 37 commits into
scikit-learn-contrib:masterfrom
glemaitre:fix_doc
Oct 31, 2019
Merged

glemaitre merged 37 commits into
scikit-learn-contrib:masterfrom
glemaitre:fix_doc

Conversation

@glemaitre

@glemaitre glemaitre commented Oct 29, 2019

Copy link
Copy Markdown
Member

closes #616

@codecov

codecov Bot commented Oct 29, 2019

Copy link
Copy Markdown

Codecov Report

Merging #617 into master will decrease coverage by 0.68%.
The diff coverage is 98.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #617      +/-   ##
==========================================
- Coverage   98.92%   98.23%   -0.69%     
==========================================
  Files          85       83       -2     
  Lines        5310     4709     -601     
==========================================
- Hits         5253     4626     -627     
- Misses         57       83      +26
Impacted Files Coverage Δ
imblearn/utils/__init__.py 100% <ø> (ø) ⬆️
imblearn/under_sampling/__init__.py 100% <ø> (ø) ⬆️
...rn/under_sampling/_prototype_selection/__init__.py 100% <ø> (ø) ⬆️
imblearn/metrics/__init__.py 100% <ø> (ø) ⬆️
imblearn/datasets/tests/test_imbalance.py 100% <ø> (ø) ⬆️
imblearn/under_sampling/base.py 100% <100%> (ø) ⬆️
imblearn/over_sampling/tests/test_adasyn.py 100% <100%> (ø) ⬆️
imblearn/utils/tests/test_deprecation.py 100% <100%> (ø) ⬆️
imblearn/over_sampling/tests/test_smote.py 100% <100%> (ø) ⬆️
imblearn/keras/__init__.py 100% <100%> (ø) ⬆️
... and 73 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbe3820...034270f. Read the comment docs.

@glemaitre glemaitre changed the title DOC issue compiling documentation MAINT compatibility with scikit-learn 0.22 Oct 30, 2019
@pep8speaks

pep8speaks commented Oct 31, 2019

Copy link
Copy Markdown

Hello @glemaitre! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 47:1: E402 module level import not at top of file

Comment last updated at 2019-10-31 16:18:08 UTC

@lgtm-com

lgtm-com Bot commented Oct 31, 2019

Copy link
Copy Markdown

This pull request fixes 7 alerts when merging e31c6c6 into bbe3820 - view on LGTM.com

fixed alerts:

  • 7 for Unused import

@lgtm-com

lgtm-com Bot commented Oct 31, 2019

Copy link
Copy Markdown

This pull request fixes 7 alerts when merging 3603cdf into bbe3820 - view on LGTM.com

fixed alerts:

  • 7 for Unused import

@glemaitre
glemaitre merged commit 7032dcb into scikit-learn-contrib:master Oct 31, 2019
@lgtm-com

lgtm-com Bot commented Oct 31, 2019

Copy link
Copy Markdown

This pull request fixes 7 alerts when merging 034270f into bbe3820 - view on LGTM.com

fixed alerts:

  • 7 for Unused import

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use of private API will break with scikit-learn 0.22

2 participants