Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH add validate parameter to FunctionSampler #637

Merged
merged 11 commits into from Nov 15, 2019

Conversation

@glemaitre
Copy link
Member

glemaitre commented Nov 14, 2019

Reference Issue

closes #610

What does this implement/fix? Explain your changes.

Add a parameter validate in FunctionSampler to bypass the validation and make it possible to pass any type of target y.

Any other comments?

glemaitre added 9 commits Nov 13, 2019
fix
@glemaitre glemaitre force-pushed the scikit-learn-contrib:master branch from 8b61219 to 0493258 Nov 14, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 14, 2019

Codecov Report

Merging #637 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #637      +/-   ##
==========================================
+ Coverage   97.94%   97.94%   +<.01%     
==========================================
  Files          83       83              
  Lines        4810     4825      +15     
==========================================
+ Hits         4711     4726      +15     
  Misses         99       99
Impacted Files Coverage Δ
imblearn/tests/test_base.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0493258...e75a9ad. Read the comment docs.

@glemaitre glemaitre merged commit f7e477d into scikit-learn-contrib:master Nov 15, 2019
7 checks passed
7 checks passed
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No new or fixed alerts
Details
ci/circleci: python3 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 97.94%)
Details
codecov/project 97.94% (+<.01%) compared to 0493258
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.