Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH accept non finite values in random samplers #643

Merged
merged 3 commits into from Nov 16, 2019

Conversation

glemaitre
Copy link
Member

@glemaitre glemaitre commented Nov 16, 2019

Reference Issue

closes #605

What does this implement/fix? Explain your changes.

Avoir rejecting array if they contain NaN or Inf in Random*Sampler. These samplers do not use the these information to sample therefore this is safe to propagate them.

Any other comments?

@glemaitre glemaitre merged commit 45b538c into scikit-learn-contrib:master Nov 16, 2019
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant