Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX incorporate resampling when computing OOB score in BRF #656

Merged
merged 3 commits into from Dec 5, 2019

Conversation

glemaitre
Copy link
Member

@glemaitre glemaitre commented Dec 5, 2019

closes #655

Resampling was not taken into account when computing the OOB score. Thus, the results was incorparting in-sample and leading to over-optimistic results.

@pep8speaks
Copy link

@pep8speaks pep8speaks commented Dec 5, 2019

Hello @glemaitre! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-12-05 12:42:56 UTC

@lgtm-com
Copy link

@lgtm-com lgtm-com bot commented Dec 5, 2019

This pull request fixes 5 alerts when merging e4143a0 into 3839df1 - view on LGTM.com

fixed alerts:

  • 2 for Wrong name for an argument in a call
  • 2 for Mismatch in multiple assignment
  • 1 for Module is imported with 'import' and 'import from'

@glemaitre glemaitre merged commit d8472f4 into scikit-learn-contrib:master Dec 5, 2019
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants