Accept column vectors when having binary or multiclass targets #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chkoar
changed the title
added 2 commits
January 31, 2020 14:35
This reverts commit e860876.
Codecov Report
@@ Coverage Diff @@
## master #673 +/- ##
=========================================
Coverage ? 98.59%
=========================================
Files ? 82
Lines ? 4850
Branches ? 0
=========================================
Hits ? 4782
Misses ? 68
Partials ? 0
Continue to review full report at Codecov.
|
added 3 commits
January 31, 2020 15:10
This reverts commit e860876.
glemaitre
reviewed
Jan 31, 2020
| random_state=0, | ||
| ) | ||
|
|
||
| y = y.reshape(-1, 1) # Make the target 2d |
There was a problem hiding this comment.
Could you add another check when having pandas Series and DataFrame
There was a problem hiding this comment.
I was thinking to make a follow up PR to address #666. So, this check could be added in that same PR. What do you think?
|
@glemaitre after a retrigger all tests passed. |
chkoar
changed the title
glemaitre
pushed a commit
that referenced
this pull request
Feb 16, 2020
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixes #671
What does this implement/fix? Explain your changes.
Converts the target vector in the binary or multiclass case
Any other comments?
#666 (OMG what an evil number) is related but it will be solved probably in a following PR because there is an extra check of the name in the
ywhich I think that is redundant.