New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pipeline caching for older versions of joblib #687
Fix pipeline caching for older versions of joblib #687
Conversation
Codecov Report
@@ Coverage Diff @@
## master #687 +/- ##
==========================================
+ Coverage 96.37% 96.45% +0.08%
==========================================
Files 82 82
Lines 4989 4999 +10
==========================================
+ Hits 4808 4822 +14
+ Misses 181 177 -4
Continue to review full report at Codecov.
|
azure-pipelines.yml
Outdated
@@ -37,7 +37,6 @@ jobs: | |||
PANDAS_VERSION: '*' | |||
TEST_DOCSTRINGS: 'true' | |||
JOBLIB_VERSION: '*' | |||
CHECK_WARNINGS: 'true' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a test be cause I was getting errors about FutureWarnings. I believe those tests should run only on cron based tasks because otherwise we get unrelated errors to PRs. What to you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are running those in scikit-learn. It allows to catch the warnings and ensure that you don't introduce new one by calling deprecated stuff. If this is in test, you can always filter a specific warning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, what do you propose? I think that the main thing is not the deprecation and future warnings as errors. We should run those in periodic manner against the latest version of scikit-learn
otherwise we are getting errors that are irrelevant to PRs. So, we could test against the latest (released) version of scikit-learn and even a previous one. The latest could be tested in schedule. Or something like that.
This PR could be merged after #691 |
Reference Issue
Fixes #685