Fix pipeline caching for older versions of joblib#687
Conversation
Codecov Report
@@ Coverage Diff @@
## master #687 +/- ##
==========================================
+ Coverage 96.37% 96.45% +0.08%
==========================================
Files 82 82
Lines 4989 4999 +10
==========================================
+ Hits 4808 4822 +14
+ Misses 181 177 -4
Continue to review full report at Codecov.
|
| PANDAS_VERSION: '*' | ||
| TEST_DOCSTRINGS: 'true' | ||
| JOBLIB_VERSION: '*' | ||
| CHECK_WARNINGS: 'true' |
There was a problem hiding this comment.
As a test be cause I was getting errors about FutureWarnings. I believe those tests should run only on cron based tasks because otherwise we get unrelated errors to PRs. What to you think?
There was a problem hiding this comment.
We are running those in scikit-learn. It allows to catch the warnings and ensure that you don't introduce new one by calling deprecated stuff. If this is in test, you can always filter a specific warning.
There was a problem hiding this comment.
So, what do you propose? I think that the main thing is not the deprecation and future warnings as errors. We should run those in periodic manner against the latest version of scikit-learn otherwise we are getting errors that are irrelevant to PRs. So, we could test against the latest (released) version of scikit-learn and even a previous one. The latest could be tested in schedule. Or something like that.
|
This PR could be merged after #691 |
Reference Issue
Fixes #685