Skip to content

Fix pipeline caching for older versions of joblib#687

Merged
glemaitre merged 12 commits into
scikit-learn-contrib:masterfrom
chkoar:fix_685_pipeline
Jun 8, 2020
Merged

Fix pipeline caching for older versions of joblib#687
glemaitre merged 12 commits into
scikit-learn-contrib:masterfrom
chkoar:fix_685_pipeline

Conversation

@chkoar
Copy link
Copy Markdown
Member

@chkoar chkoar commented Feb 20, 2020

Reference Issue

Fixes #685

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 20, 2020

Codecov Report

Merging #687 into master will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #687      +/-   ##
==========================================
+ Coverage   96.37%   96.45%   +0.08%     
==========================================
  Files          82       82              
  Lines        4989     4999      +10     
==========================================
+ Hits         4808     4822      +14     
+ Misses        181      177       -4     
Impacted Files Coverage Δ
imblearn/utils/_show_versions.py 100.00% <ø> (ø)
imblearn/pipeline.py 97.91% <100.00%> (+3.97%) ⬆️
imblearn/tests/test_pipeline.py 97.68% <100.00%> (+0.03%) ⬆️
imblearn/utils/tests/test_show_versions.py 100.00% <100.00%> (ø)
imblearn/ensemble/tests/test_forest.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 703cee1...fcac0d9. Read the comment docs.

@pep8speaks
Copy link
Copy Markdown

pep8speaks commented Feb 21, 2020

Hello @chkoar! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-06-08 18:30:19 UTC

Comment thread azure-pipelines.yml
PANDAS_VERSION: '*'
TEST_DOCSTRINGS: 'true'
JOBLIB_VERSION: '*'
CHECK_WARNINGS: 'true'
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a test be cause I was getting errors about FutureWarnings. I believe those tests should run only on cron based tasks because otherwise we get unrelated errors to PRs. What to you think?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are running those in scikit-learn. It allows to catch the warnings and ensure that you don't introduce new one by calling deprecated stuff. If this is in test, you can always filter a specific warning.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, what do you propose? I think that the main thing is not the deprecation and future warnings as errors. We should run those in periodic manner against the latest version of scikit-learn otherwise we are getting errors that are irrelevant to PRs. So, we could test against the latest (released) version of scikit-learn and even a previous one. The latest could be tested in schedule. Or something like that.

Comment thread imblearn/pipeline.py Outdated
@chkoar
Copy link
Copy Markdown
Member Author

chkoar commented Feb 28, 2020

This PR could be merged after #691

@glemaitre glemaitre merged commit f21bdea into scikit-learn-contrib:master Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Error when using transformer caching with Pipeline object

3 participants