fix: default parameter value inconsistent from doc#711
Merged
glemaitre merged 4 commits intoscikit-learn-contrib:masterfrom Jun 8, 2020
Merged
fix: default parameter value inconsistent from doc#711glemaitre merged 4 commits intoscikit-learn-contrib:masterfrom
glemaitre merged 4 commits intoscikit-learn-contrib:masterfrom
Conversation
glemaitre
approved these changes
Jun 8, 2020
Member
glemaitre
left a comment
There was a problem hiding this comment.
LGTM thanks for catching this.
Codecov Report
@@ Coverage Diff @@
## master #711 +/- ##
=======================================
Coverage 96.37% 96.37%
=======================================
Files 82 82
Lines 4989 4989
=======================================
Hits 4808 4808
Misses 181 181
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
The default value of
min_samples_leafinBalancedRandomForestClassifierconstructor is 2, but in doc, the default value is 1.Any other comments?
This default value in
RandomForestClassifier(sklearn) is also 1.