Skip to content

fix: default parameter value inconsistent from doc#711

Merged
glemaitre merged 4 commits intoscikit-learn-contrib:masterfrom
zerolfx:master
Jun 8, 2020
Merged

fix: default parameter value inconsistent from doc#711
glemaitre merged 4 commits intoscikit-learn-contrib:masterfrom
zerolfx:master

Conversation

@zerolfx
Copy link
Copy Markdown
Contributor

@zerolfx zerolfx commented May 26, 2020

What does this implement/fix? Explain your changes.

The default value of min_samples_leaf in BalancedRandomForestClassifier constructor is 2, but in doc, the default value is 1.

Any other comments?

This default value in RandomForestClassifier(sklearn) is also 1.

@glemaitre glemaitre self-assigned this Jun 8, 2020
Copy link
Copy Markdown
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for catching this.

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 8, 2020

Codecov Report

Merging #711 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #711   +/-   ##
=======================================
  Coverage   96.37%   96.37%           
=======================================
  Files          82       82           
  Lines        4989     4989           
=======================================
  Hits         4808     4808           
  Misses        181      181           
Impacted Files Coverage Δ
imblearn/ensemble/_forest.py 97.26% <ø> (ø)
imblearn/ensemble/tests/test_forest.py 100.00% <ø> (ø)
imblearn/over_sampling/_smote.py 97.22% <ø> (ø)
imblearn/pipeline.py 93.93% <ø> (ø)
...mpling/_prototype_generation/_cluster_centroids.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37f27ee...1de6ac4. Read the comment docs.

@glemaitre glemaitre merged commit 703cee1 into scikit-learn-contrib:master Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants