Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX raise proper error message when only categorical passed to SMOTE-NC #720

Merged
merged 3 commits into from Jun 9, 2020

Conversation

glemaitre
Copy link
Member

@glemaitre glemaitre commented Jun 9, 2020

closes #562

Add a proper error message when only categorical features are provided to SMOTE-NC

@codecov
Copy link

codecov bot commented Jun 9, 2020

Codecov Report

Merging #720 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #720   +/-   ##
=======================================
  Coverage   96.47%   96.48%           
=======================================
  Files          82       82           
  Lines        5026     5035    +9     
=======================================
+ Hits         4849     4858    +9     
  Misses        177      177           
Impacted Files Coverage Δ
imblearn/over_sampling/_smote.py 97.23% <100.00%> (+0.01%) ⬆️
imblearn/over_sampling/tests/test_smote_nc.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91b99ce...f1355e2. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Jun 9, 2020

This pull request introduces 1 alert when merging ecc33d0 into 91b99ce - view on LGTM.com

new alerts:

  • 1 for Unused import

@glemaitre glemaitre merged commit a8a8adb into scikit-learn-contrib:master Jun 9, 2020
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant