Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT deprecate passing kwargs by position #721

Merged
merged 4 commits into from Jun 9, 2020

Conversation

glemaitre
Copy link
Member

@glemaitre glemaitre commented Jun 9, 2020

closes #717

Not allowing kwargs by position anymore. It is requiring a round of deprecation.

@pep8speaks
Copy link

@pep8speaks pep8speaks commented Jun 9, 2020

Hello @glemaitre! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 54:1: E402 module level import not at top of file

Comment last updated at 2020-06-09 09:36:33 UTC

@codecov
Copy link

@codecov codecov bot commented Jun 9, 2020

Codecov Report

Merging #721 into master will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #721      +/-   ##
==========================================
+ Coverage   96.49%   96.55%   +0.06%     
==========================================
  Files          82       82              
  Lines        5043     5140      +97     
==========================================
+ Hits         4866     4963      +97     
  Misses        177      177              
Impacted Files Coverage Δ
imblearn/combine/_smote_enn.py 100.00% <100.00%> (ø)
imblearn/combine/_smote_tomek.py 100.00% <100.00%> (ø)
imblearn/datasets/_imbalance.py 88.23% <100.00%> (+1.56%) ⬆️
imblearn/datasets/_zenodo.py 96.77% <100.00%> (+0.10%) ⬆️
imblearn/datasets/tests/test_imbalance.py 100.00% <100.00%> (ø)
imblearn/ensemble/_bagging.py 97.82% <100.00%> (+0.09%) ⬆️
imblearn/ensemble/_easy_ensemble.py 100.00% <100.00%> (ø)
imblearn/ensemble/_forest.py 97.36% <100.00%> (+0.03%) ⬆️
imblearn/ensemble/_weight_boosting.py 97.75% <100.00%> (+0.05%) ⬆️
imblearn/keras/_generator.py 52.85% <100.00%> (+2.11%) ⬆️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a2d34f...0302636. Read the comment docs.

@glemaitre glemaitre merged commit c960cfc into scikit-learn-contrib:master Jun 9, 2020
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants