-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[MRG] ROSE #754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] ROSE #754
Conversation
Code should be ok. I have some issue with documentation build, though. Can anyone help me to give a direction, or tips about what's wrong? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking really good!
A few final changes (see comments), then I think this will be good to merge.
Can you also add a note to the "Enhancements" section for 0.7? https://github.com/scikit-learn-contrib/imbalanced-learn/blob/master/doc/whats_new/v0.7.rst |
Sure.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments for the last few fixes.
Otherwise, LGTM!
Reference Issue
N/A
What does this implement/fix? Explain your changes.
Implementation of ROSE over-sampler method
Any other comments?
N/A