Skip to content

MNT remove requirements files and move it in setup.py - #816

Merged
glemaitre merged 3 commits into
scikit-learn-contrib:masterfrom
glemaitre:is/810
Feb 18, 2021
Merged

glemaitre merged 3 commits into
scikit-learn-contrib:masterfrom
glemaitre:is/810

Conversation

@glemaitre

Copy link
Copy Markdown
Member

closes #810

Remove the requirements file in favour of extras_require in setup.py.

@pep8speaks

pep8speaks commented Feb 17, 2021 •

Copy link
Copy Markdown

Hello @glemaitre! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 23:11: F821 undefined name 'version'

Comment last updated at 2021-02-17 21:17:01 UTC

@glemaitre
glemaitre merged commit 76abfa4 into scikit-learn-contrib:master Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dependencies and requirement files

2 participants