Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLEP006 on Sample Properties #16

Draft
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@jnothman
Copy link
Member

commented Mar 7, 2019

No description provided.

@adrinjalali

This comment has been minimized.

Copy link
Member

commented Mar 7, 2019

and (somehow) move slep004 to rejected?

validation
* (maybe in scope) passing sample properties (e.g. `sample_weight`) to some
scorers and not others in a multi-metric cross-validation setup
* (likley out of scope) passing sample properties to non-fit methods, for

This comment has been minimized.

Copy link
@adrinjalali

adrinjalali Mar 7, 2019

Member

is this particularly "harder" to implement than the others?

This comment has been minimized.

Copy link
@jnothman

jnothman Mar 7, 2019

Author Member

Well firstly the use cases for it will need further definition; we don't currently pass around anything like weights to predict or transform methods. But yes it is hard in part because we have fused method like fit_transform

This comment has been minimized.

Copy link
@adrinjalali

adrinjalali Mar 8, 2019

Member

yeah, I guess the sample_weight usecases maybe less frequent than things which take gender or race into account. There a predict may be some postprocessing on the output of another estimator based on these sample properties.

@adrinjalali

This comment has been minimized.

Copy link
Member

commented Apr 4, 2019

Could I somehow be of any help here @jnothman ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.