validation_curve and learning_curve should support fit_params

[jnothman]

Similar functions like cross_validation and cross_val_score support fit_params to pass sample_weight etc into the model being fitted. These other model selection routines should probably support the same.

[ido-sh]

Hi @jnothman, can I give it a shot?

[jnothman]

Sure, have a go. Remember to include or update a test

[ggc87]

Hi @jnothman,
I was checking this issue and I just saw that the tests for the validation_curve are in test_learning_curve, which is testing the deprecated implementation in learning_curve.py.
Should this test moved in test_cross_validation where validation_curve is implemented now?

[jnothman]

don't worry about the deprecated module. tests should be in model_selection/tests

[ggc87]

Right, I didn't see that the tests are in the model_selection/tests folder, I just saw the test_validation.py in the main test folder.

[gxyd]

@ggc87 @ido-sh Is anyone here working on the issue? I have a pull request ready locally, but since you already asked to work on the issue, I'll wait if you still want to work on it.

[ido-sh]

@gxyd if yours is ready then please feel free to go ahead

[ggc87]

@gxyd same here I was waiting for @ido-sh since he asked before.

[gxyd]

I've close my PR.

[ggc87]

@gxyd I'm sorry this has been a bit confusing. You had no reason to close your PR, you can go ahead :)

[akshkr]

Can I take this?

[jnothman]

This is in progress.

…

On 13 December 2017 at 16:25, Akash ***@***.***> wrote: Can I take this? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#10252 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEz66b-whp3Sv9T7Kz4nMO4C6ex3FzCks5s_1_SgaJpZM4Q1Y7O> .

[uwaisiqbal]

Has this been implemented? I wanted to use this for something I'm currently working on.

[gxyd]

See #10273 . I need to address a few comments before it becomes available.

[littlewine]

What is the status of this item?
In case I am not mistaken, the code is ready and awaiting to be merged in the master branch, right?

Can I use the code already by updating the code from here?

Thanks in advance for your answer and sorry if I am not supposed to post such questions here :)