New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
funcsigs.signature() doesn't support classes on PyPy3 #11016
Comments
The On Python 3.4+ it's probably better to use Is this an issue for PyPy 2? |
That repo only has version 0.4 from 2013 but PyPI has 1.0.2 from 2016. Anyway, There seems to be an issue on pypy2 as well, but I haven't debugged it yet. |
So, yes, there is a similar issue on pypy2. There, after modifying the example to use a new-style class, the result is: |
So we can just make sure everything is a new-style class as a workaround? There shouldn't be too many old-style classes since e.g. anything inheriting from |
A workaround of using new-style classes was applied in #11010, I believe. Closing. |
Description
sklearn.externals.funcsigs.signature()
doesn't work (i.e. raises a ValueError) with user-defined classes on PyPy3. This is the source of most of the test failures seen in #11010.The external project
funcsigs
seems unmaintained and doesn't appear to have a publicly accessible repo containing the last released version, so I'm not sure how to proceed with testing and fixing this issue.Steps/Code to Reproduce
Expected Results
On CPython 3.5:
(but note that you get a ValueError for classes that don't define
__init__
)Actual Results
On pypy3.5:
The text was updated successfully, but these errors were encountered: