Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cross_validate and cross_val_score raise errors_score warning but don't expose it #11576

Closed
amueller opened this Issue Jul 16, 2018 · 4 comments

Comments

Projects
3 participants
@amueller
Copy link
Member

amueller commented Jul 16, 2018

Via #11570.
Both cross_val_score and cross_validate provide deprecation warnings when an error happens during the process, telling users to set error_score. But they don't expose error_score. We either need to expose error_score in these two functions or explicitly pass error_score='raise' to _fit_and_score.

I'm pretty agnostic which of the two we do. I guess it's less likely that some of the fold will error than that some parameter settings will error in GridSearchCV.

@amueller amueller added the Blocker label Jul 16, 2018

@amueller amueller added this to the 0.20 milestone Jul 16, 2018

@samronsin

This comment has been minimized.

Copy link
Contributor

samronsin commented Jul 17, 2018

Working on this.

@amueller

This comment has been minimized.

Copy link
Member Author

amueller commented Jul 17, 2018

same for learning_curve. we need to check if we use _fit_and_score in other places. Or maybe we should have not changed the default in _fit_and_score but in GridSearchCV instead.

@samronsin

This comment has been minimized.

Copy link
Contributor

samronsin commented Jul 17, 2018

Same for validation_curve as well.
There are two other occurences of _fit_and_score: in fit_grid_point and the fit method of BaseSearchCV, but errors_score is exposed in both functions.

@jnothman

This comment has been minimized.

Copy link
Member

jnothman commented Jul 19, 2018

scikit-learn 0.20 automation moved this from Issues tagged to Done Jul 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.