Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on early stopping by default in HistGradientBoosting estimators #14503

Closed
4 tasks
NicolasHug opened this issue Jul 29, 2019 · 4 comments · Fixed by #14516
Closed
4 tasks

Turn on early stopping by default in HistGradientBoosting estimators #14503

NicolasHug opened this issue Jul 29, 2019 · 4 comments · Fixed by #14516
Labels
Easy Well-defined and straightforward way to resolve

Comments

@NicolasHug
Copy link
Member

Following #14303, let's turn on early-stopping by default in HistGradientBoostingRegressor and HistGradientBoostingClassifier.

TODO:

  • change default
  • add small test
  • update tests that might fail due to default change
  • add short sentence in docstring indicating that early stopping is enabled by default.

Maybe @johannfaouzi would like to give it a try?

@johannfaouzi
Copy link
Contributor

Yes, for sure.

@ManishAradwad
Copy link
Contributor

Hey!! Is this issue still open?? I would like to help

@NicolasHug
Copy link
Member Author

Hi @ManishAradwad, we already have a PR opened for this (see above). Thanks!

@ManishAradwad
Copy link
Contributor

Thanks, I'll look for another one..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy Well-defined and straightforward way to resolve
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants