[DPGMM - _update_concentrations fail implementation] #1764

Closed
tamnguyenthe opened this Issue Mar 12, 2013 · 2 comments

Projects

None yet

3 participants

in method update_concentration, DPGMM
i think it should be:
self.gamma
[i, 2] = self.gamma_[i + 1, 2] + sz[i+1]
instead of:
self.gamma_[i, 2] = self.gamma_[i + 1, 2] + sz[i]

@amueller amueller added this to the 0.15.1 milestone Jul 18, 2014
Owner

I agree. Maybe @alextp can confirm. Otherwise sz[self.n_components] is not included in the sum.
Maybe we should write

self.gamma_[:-1, 2] = np.cumsum(sz[::-1])[::-1][1:]

but that is also not super readable.

@amueller amueller modified the milestone: 0.16, 0.17 Sep 11, 2015
@amueller amueller modified the milestone: 0.18, 0.17 Sep 20, 2015
Owner
ogrisel commented Sep 10, 2016

Closing: the new Dirichlet process GMM re-write has been merged in master.

@ogrisel ogrisel closed this Sep 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment