Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website #2286

Closed
NelleV opened this issue Jul 28, 2013 · 10 comments
Closed

Website #2286

NelleV opened this issue Jul 28, 2013 · 10 comments
Labels

Comments

@NelleV
Copy link
Member

@NelleV NelleV commented Jul 28, 2013

Here are a list of things we need to change in the website:

  • the design is slow to load, hence it resizes it automatically after loading
  • the top menu needs to be rewritten completely to avoid alignment problem (see ogrisel's computer)
  • Fork me on github not working.
  • Disable the github fork ribbon on small (mobile) screens
  • Sidebar should collapse automatically on very small screens.
  • Check that we are using the asynchronous syntax for the Google Analytics tracker: https://developers.google.com/analytics/devguides/collection/gajs/?hl=fr
@dengemann
Copy link
Contributor

@dengemann dengemann commented Jul 28, 2013

@NelleV on iOS the 'Fork Me' banner some parts of the navigation and the google search bar seem to collide.

@NelleV
Copy link
Member Author

@NelleV NelleV commented Jul 28, 2013

@dengemann this is fixed.

@GaelVaroquaux
Copy link
Member

@GaelVaroquaux GaelVaroquaux commented Jul 28, 2013

@dengemann this is fixed.

Can you give the URL of the preview you are working on, please.

@dengemann
Copy link
Contributor

@dengemann dengemann commented Jul 28, 2013

@dengemann this is fixed.

does not look fixed on my iPhone (http://scikit-learn.org/dev/).

@NelleV
Copy link
Member Author

@NelleV NelleV commented Jul 28, 2013

@dengemann it's not build on this website.
to test the updated website use this: http://cbio.ensmp.fr/~nvaroquaux/scikit-learn/index.html

@dengemann
Copy link
Contributor

@dengemann dengemann commented Jul 28, 2013

to test the updated website use this: http://cbio.ensmp.fr/~nvaroquaux/scikit-learn/index.html

@NelleV now the text in the main table is truncated, the texts are not fully displayed.

@glouppe
Copy link
Member

@glouppe glouppe commented Jul 28, 2013

Hi guys,

I am still in the Thalys. To improve user experience, the trick is to load
all js files at very end of the page, ie just before /body. I am quite sure
Bootstrap is not the culprit, since the js file is local. However the
Google ones are not (in particular the one for the input search).

I will have a look later today if you need my help.

Gilles

On Sunday, 28 July 2013, Varoquaux notifications@github.com wrote:

@dengemann it's not build on this website.
to test the updated website use this:
http://cbio.ensmp.fr/~nvaroquaux/scikit-learn/index.html


Reply to this email directly or view it on GitHub.<
https://github.com/notifications/beacon/_QTdss38AqWGGkZjXC7Jr96TxWQ9gP2aG7vf_Od_fM-6wSkAC_TrRl5qncIWTn3g.gif

@glouppe
Copy link
Member

@glouppe glouppe commented Jul 28, 2013

Also, we should use minified versions wherever we can. I will do that in a
couple of hours.

On Sunday, 28 July 2013, Gilles Louppe g.louppe@gmail.com wrote:

Hi guys,

I am still in the Thalys. To improve user experience, the trick is to
load all js files at very end of the page, ie just before /body. I am quite
sure Bootstrap is not the culprit, since the js file is local. However the
Google ones are not (in particular the one for the input search).

I will have a look later today if you need my help.

Gilles

On Sunday, 28 July 2013, Varoquaux notifications@github.com wrote:

@dengemann it's not build on this website.
to test the updated website use this:
http://cbio.ensmp.fr/~nvaroquaux/scikit-learn/index.html


Reply to this email directly or view it on GitHub.<
https://github.com/notifications/beacon/_QTdss38AqWGGkZjXC7Jr96TxWQ9gP2aG7vf_Od_fM-6wSkAC_TrRl5qncIWTn3g.gif

This was referenced Jul 28, 2013
@amueller
Copy link
Member

@amueller amueller commented Jan 6, 2014

Is this issue still relevant?

@larsmans
Copy link
Member

@larsmans larsmans commented Jun 16, 2014

Closing because we already have another "website is slow" issue.

@larsmans larsmans closed this Jun 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants