Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

numpy version comparison #3431

Closed
argriffing opened this issue Jul 18, 2014 · 1 comment
Closed

numpy version comparison #3431

argriffing opened this issue Jul 18, 2014 · 1 comment
Labels
Bug

Comments

@argriffing
Copy link

The new numpy development versions 1.10.0.dev-whatever are uncovering version comparison bugs, so I thought I'd check scikit-learn. The comparison in line
https://github.com/scikit-learn/scikit-learn/blob/0.15.X/sklearn/externals/joblib/numpy_pickle.py#L110
looks wrong, and maybe there are others.
@arjoly arjoly added the Bug label Jul 18, 2014
@larsmans
Copy link
Member

larsmans commented Aug 7, 2014

That one's in joblib; fixed in 046f7e8. I did a git grep __version__, which turns up various ways of comparing NumPy and SciPy versions, but no more naïve ones. Closing, thanks for the heads-up!

@larsmans larsmans closed this as completed Aug 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@argriffing @larsmans @arjoly