New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GradientBoostingRegressor always sets presort to auto #5857

Closed
mcculloh opened this Issue Nov 16, 2015 · 4 comments

Comments

Projects
None yet
4 participants
@mcculloh

mcculloh commented Nov 16, 2015

In the call to super inside __init__() GradientBoostingRegressor does not pass thru the presort variable to the superclass:

    super(GradientBoostingRegressor, self).__init__(
        loss=loss, learning_rate=learning_rate, n_estimators=n_estimators,
        ...
        max_leaf_nodes=max_leaf_nodes, warm_start=warm_start,
        presort='auto')
@amueller

This comment has been minimized.

Member

amueller commented Nov 16, 2015

ping @jmschrei @glouppe @arjoly
again ;)

@jmschrei

This comment has been minimized.

Member

jmschrei commented Nov 16, 2015

I'm suspecting that that PR introduced both of the issues. I think there is a check_X_y call which is causing the other issue which I missed since I was using smaller datasets. I've been swamped with a few presentations I have to do this week, but I'll be available to take a look at both soon.

@mcculloh

This comment has been minimized.

mcculloh commented Nov 16, 2015

I added a second commit. It looks like the logic to activate the presort would only actually work if you explicitly set the parameter to 'True' . Since the super() call clobbers this, I don't know that it ever actually got turned on.

@glouppe

This comment has been minimized.

Member

glouppe commented Nov 20, 2015

Fixed in #5858

@glouppe glouppe closed this Nov 20, 2015

ogrisel added a commit that referenced this issue Jan 29, 2016

ogrisel added a commit that referenced this issue Jan 29, 2016

glemaitre added a commit to glemaitre/scikit-learn that referenced this issue Feb 13, 2016

yarikoptic added a commit to yarikoptic/scikit-learn that referenced this issue Feb 19, 2016

Merge tag '0.17.1' into releases
* tag '0.17.1': (29 commits)
  Release 0.17.1
  MAINT remove non-existing cache folder in 0.17.X branch
  FIX cythonize TSNE
  MAINT simplify freeing logic for Barnes-Hut SNE memory leak fix
  Fix memory leak in Barnes-Hut SNE
  FIX check_build_doc.py false positive detections
  MAINT more informative output to circle/check_build_doc.py
  FIX fetch_california_housing
  FIX in randomized_svd flip sign
  Updated examples and tests that use scipy's lena
  DOC whats_new entry for scikit-learn#6258
  fix joblib error in LatentDirichletAllocation
  MAINT fix / speedup travis on 0.17.X
  MAINT Upgrade pip in appveyor and display version
  DOC missing changelog entry for scikit-learn#5857
  DOC add fix for scikit-learn#6147 to the changelog
  FIX 6147: ensure that AUC is always a float
  TST non-regression test for scikit-learn#6147, roc_auc on memmap data
  Added changelog entry about scikit-learn#6196
  Fix reading of bunch pickles
  ...

yarikoptic added a commit to yarikoptic/scikit-learn that referenced this issue Feb 19, 2016

Merge branch 'releases' into dfsg
* releases: (29 commits)
  Release 0.17.1
  MAINT remove non-existing cache folder in 0.17.X branch
  FIX cythonize TSNE
  MAINT simplify freeing logic for Barnes-Hut SNE memory leak fix
  Fix memory leak in Barnes-Hut SNE
  FIX check_build_doc.py false positive detections
  MAINT more informative output to circle/check_build_doc.py
  FIX fetch_california_housing
  FIX in randomized_svd flip sign
  Updated examples and tests that use scipy's lena
  DOC whats_new entry for scikit-learn#6258
  fix joblib error in LatentDirichletAllocation
  MAINT fix / speedup travis on 0.17.X
  MAINT Upgrade pip in appveyor and display version
  DOC missing changelog entry for scikit-learn#5857
  DOC add fix for scikit-learn#6147 to the changelog
  FIX 6147: ensure that AUC is always a float
  TST non-regression test for scikit-learn#6147, roc_auc on memmap data
  Added changelog entry about scikit-learn#6196
  Fix reading of bunch pickles
  ...

yarikoptic added a commit to yarikoptic/scikit-learn that referenced this issue Feb 19, 2016

Merge branch 'dfsg' into debian
* dfsg: (29 commits)
  Release 0.17.1
  MAINT remove non-existing cache folder in 0.17.X branch
  FIX cythonize TSNE
  MAINT simplify freeing logic for Barnes-Hut SNE memory leak fix
  Fix memory leak in Barnes-Hut SNE
  FIX check_build_doc.py false positive detections
  MAINT more informative output to circle/check_build_doc.py
  FIX fetch_california_housing
  FIX in randomized_svd flip sign
  Updated examples and tests that use scipy's lena
  DOC whats_new entry for scikit-learn#6258
  fix joblib error in LatentDirichletAllocation
  MAINT fix / speedup travis on 0.17.X
  MAINT Upgrade pip in appveyor and display version
  DOC missing changelog entry for scikit-learn#5857
  DOC add fix for scikit-learn#6147 to the changelog
  FIX 6147: ensure that AUC is always a float
  TST non-regression test for scikit-learn#6147, roc_auc on memmap data
  Added changelog entry about scikit-learn#6196
  Fix reading of bunch pickles
  ...

mannby pushed a commit to mannby/scikit-learn that referenced this issue Apr 22, 2016

TomDLT added a commit to TomDLT/scikit-learn that referenced this issue Oct 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment