SpectralBiclustering.fit doesn't return self #6126

Closed
amueller opened this Issue Jan 6, 2016 · 6 comments

Comments

Projects
None yet
4 participants
@amueller
Member

amueller commented Jan 6, 2016

need to check for coclustering, too.

@maniteja123

This comment has been minimized.

Show comment
Hide comment
@maniteja123

maniteja123 Jan 6, 2016

Contributor

Hi can I work on this issue ? Thanks.

Contributor

maniteja123 commented Jan 6, 2016

Hi can I work on this issue ? Thanks.

@amueller

This comment has been minimized.

Show comment
Hide comment
@amueller

amueller Jan 6, 2016

Member

you sure can :)

Member

amueller commented Jan 6, 2016

you sure can :)

@maniteja123

This comment has been minimized.

Show comment
Hide comment
@maniteja123

maniteja123 Jan 6, 2016

Contributor

Needed to clarify small thing. Basically this fit method of the base class needs to return self. And since it calls the corresponding fit_ method depending on biclustering or coclustering, they needn't be touched.

And my laptop just stopped working. So looked into the issue from my phone. Please let me know if I am missing something here.

Thanks.

Contributor

maniteja123 commented Jan 6, 2016

Needed to clarify small thing. Basically this fit method of the base class needs to return self. And since it calls the corresponding fit_ method depending on biclustering or coclustering, they needn't be touched.

And my laptop just stopped working. So looked into the issue from my phone. Please let me know if I am missing something here.

Thanks.

@vinayak-mehta

This comment has been minimized.

Show comment
Hide comment
@vinayak-mehta

vinayak-mehta Jan 6, 2016

Contributor

@maniteja123 That should work. But for chaining purposes, I think we might need to return self from SpectralBiclustering.fit too. (same for coclustering)

Contributor

vinayak-mehta commented Jan 6, 2016

@maniteja123 That should work. But for chaining purposes, I think we might need to return self from SpectralBiclustering.fit too. (same for coclustering)

@maniteja123

This comment has been minimized.

Show comment
Hide comment
@maniteja123

maniteja123 Jan 7, 2016

Contributor

@vinayak-mehta Thanks for the response. But presently fit calls self._fit. According to this change, fit should be returning self._fit which in turn returns self. But since these are methods of the same class, wouldn't it be better to call self._fit and then return self in fit ?

Contributor

maniteja123 commented Jan 7, 2016

@vinayak-mehta Thanks for the response. But presently fit calls self._fit. According to this change, fit should be returning self._fit which in turn returns self. But since these are methods of the same class, wouldn't it be better to call self._fit and then return self in fit ?

@amueller

This comment has been minimized.

Show comment
Hide comment
@amueller

amueller Jul 15, 2016

Member

If anyone in the sprint wants to work on this, please check the error in #6141 and see if you can figure out where it comes from.

Member

amueller commented Jul 15, 2016

If anyone in the sprint wants to work on this, please check the error in #6141 and see if you can figure out where it comes from.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment