Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
SelectFromModel - hyperparameters of an estimator are not changed in a Pipeline #7756
feature_selection.SelectFromModel within Pipeline.
Steps/Code to Reproduce
The hyperparameters of SelectFromModel.estimator_ should change with set_params method.
Function set_params actually modifies SelectFromModel.estimator but SelectFromModel.estimator_ is used instead with preset params.
The repeated use of SelectFromModel does not change SelectFromModel.estimator_
Yes, a misguided feature added here: https://github.com/scikit-learn/scikit-learn/pull/4242/files#diff-f85e12a6fa5fdaf04b1f164fcc3a636dR119
Should remove it, or permit only with a