New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent parameters between QDA and LDA #7998

Closed
jnothman opened this Issue Dec 7, 2016 · 10 comments

Comments

Projects
None yet
6 participants
@jnothman
Member

jnothman commented Dec 7, 2016

QuadraticDiscriminantAnalysis has a parameter named store_covariances.

LinearDiscriminantAnalysis has a parameter named store_covariance.

One of these parameter names should be changed to the other (with a deprecation cycle)

Edit on 2016-12-27. I now see a few related issues in the code:

  • QDA also has the attribute covariances_ instead of covariance_. This should also be made consistent, i.e. another deprecation.
  • store_covariances is a parameter to QDA, but is listed, with tol, incorrectly under Attributes in the docstring
  • store_covariance only has an effect in LDA if solver is svd. Otherwise covariance_ is stored anyway.
  • The effect of store_covariance is clearly not tested and should be.

I am also leaning towards store_covariance rather than store_covariances.

@chinmay0301

This comment has been minimized.

chinmay0301 commented Dec 7, 2016

New to scikit but would like to take this one.

@chinmay0301

This comment has been minimized.

chinmay0301 commented Dec 7, 2016

Can you guide me about how to a write a deprecation cycle?

@bharat17

This comment has been minimized.

bharat17 commented Dec 7, 2016

I would like to work on it

@jnothman

This comment has been minimized.

Member

jnothman commented Dec 7, 2016

@jnothman

This comment has been minimized.

Member

jnothman commented Dec 26, 2016

This is open to contributors.

@mrbeann

This comment has been minimized.

Contributor

mrbeann commented Dec 27, 2016

I will work on this ASAP

@mrbeann

This comment has been minimized.

Contributor

mrbeann commented Dec 27, 2016

Hi, @jnothman I've just submitted a PR for this.

@Neurrone

This comment has been minimized.

Contributor

Neurrone commented Feb 18, 2017

Should I open a PR for this? There's an open PR #8130 which hasn't been active for a while.

@jnothman

This comment has been minimized.

Member

jnothman commented Feb 19, 2017

@mrbeann

This comment has been minimized.

Contributor

mrbeann commented Feb 20, 2017

Hi @jnothman , I will check it again tomorrow, thanks for your guidance.

amueller added a commit that referenced this issue Aug 1, 2017

[MRG+1] Issue#7998 : Consistent parameters between QDA and LDA (#8130)
* for #7998

* Fix some style error and add test

* Add local variable store_covariance

* better deprecation

* fix bug

* Style check

* fix covariance_

* style check

* Update

* modify test

* Formating

* update

* Update

* Add whats_new.rst

* Revert "Add whats_new.rst"

This reverts commit 4e5977d.

* whats_new

* Update for FutureWarning

* Remove warning from the setter

* add fit in test

* drop back

* Quick fix

* Small fix

* Fix

* update new

* Fix space

* Fix docstring

* fix style

* Fix

* fix assert

jnothman added a commit to jnothman/scikit-learn that referenced this issue Aug 6, 2017

[MRG+1] Issue#7998 : Consistent parameters between QDA and LDA (sciki…
…t-learn#8130)

* for scikit-learn#7998

* Fix some style error and add test

* Add local variable store_covariance

* better deprecation

* fix bug

* Style check

* fix covariance_

* style check

* Update

* modify test

* Formating

* update

* Update

* Add whats_new.rst

* Revert "Add whats_new.rst"

This reverts commit 4e5977d.

* whats_new

* Update for FutureWarning

* Remove warning from the setter

* add fit in test

* drop back

* Quick fix

* Small fix

* Fix

* update new

* Fix space

* Fix docstring

* fix style

* Fix

* fix assert

dmohns added a commit to dmohns/scikit-learn that referenced this issue Aug 7, 2017

[MRG+1] Issue#7998 : Consistent parameters between QDA and LDA (sciki…
…t-learn#8130)

* for scikit-learn#7998

* Fix some style error and add test

* Add local variable store_covariance

* better deprecation

* fix bug

* Style check

* fix covariance_

* style check

* Update

* modify test

* Formating

* update

* Update

* Add whats_new.rst

* Revert "Add whats_new.rst"

This reverts commit 4e5977d.

* whats_new

* Update for FutureWarning

* Remove warning from the setter

* add fit in test

* drop back

* Quick fix

* Small fix

* Fix

* update new

* Fix space

* Fix docstring

* fix style

* Fix

* fix assert

dmohns added a commit to dmohns/scikit-learn that referenced this issue Aug 7, 2017

[MRG+1] Issue#7998 : Consistent parameters between QDA and LDA (sciki…
…t-learn#8130)

* for scikit-learn#7998

* Fix some style error and add test

* Add local variable store_covariance

* better deprecation

* fix bug

* Style check

* fix covariance_

* style check

* Update

* modify test

* Formating

* update

* Update

* Add whats_new.rst

* Revert "Add whats_new.rst"

This reverts commit 4e5977d.

* whats_new

* Update for FutureWarning

* Remove warning from the setter

* add fit in test

* drop back

* Quick fix

* Small fix

* Fix

* update new

* Fix space

* Fix docstring

* fix style

* Fix

* fix assert

paulha added a commit to paulha/scikit-learn that referenced this issue Aug 19, 2017

[MRG+1] Issue#7998 : Consistent parameters between QDA and LDA (sciki…
…t-learn#8130)

* for scikit-learn#7998

* Fix some style error and add test

* Add local variable store_covariance

* better deprecation

* fix bug

* Style check

* fix covariance_

* style check

* Update

* modify test

* Formating

* update

* Update

* Add whats_new.rst

* Revert "Add whats_new.rst"

This reverts commit 4e5977d.

* whats_new

* Update for FutureWarning

* Remove warning from the setter

* add fit in test

* drop back

* Quick fix

* Small fix

* Fix

* update new

* Fix space

* Fix docstring

* fix style

* Fix

* fix assert

AishwaryaRK added a commit to AishwaryaRK/scikit-learn that referenced this issue Aug 29, 2017

[MRG+1] Issue#7998 : Consistent parameters between QDA and LDA (sciki…
…t-learn#8130)

* for scikit-learn#7998

* Fix some style error and add test

* Add local variable store_covariance

* better deprecation

* fix bug

* Style check

* fix covariance_

* style check

* Update

* modify test

* Formating

* update

* Update

* Add whats_new.rst

* Revert "Add whats_new.rst"

This reverts commit 4e5977d.

* whats_new

* Update for FutureWarning

* Remove warning from the setter

* add fit in test

* drop back

* Quick fix

* Small fix

* Fix

* update new

* Fix space

* Fix docstring

* fix style

* Fix

* fix assert

maskani-moh added a commit to maskani-moh/scikit-learn that referenced this issue Nov 15, 2017

[MRG+1] Issue#7998 : Consistent parameters between QDA and LDA (sciki…
…t-learn#8130)

* for scikit-learn#7998

* Fix some style error and add test

* Add local variable store_covariance

* better deprecation

* fix bug

* Style check

* fix covariance_

* style check

* Update

* modify test

* Formating

* update

* Update

* Add whats_new.rst

* Revert "Add whats_new.rst"

This reverts commit 4e5977d.

* whats_new

* Update for FutureWarning

* Remove warning from the setter

* add fit in test

* drop back

* Quick fix

* Small fix

* Fix

* update new

* Fix space

* Fix docstring

* fix style

* Fix

* fix assert

jwjohnson314 pushed a commit to jwjohnson314/scikit-learn that referenced this issue Dec 18, 2017

[MRG+1] Issue#7998 : Consistent parameters between QDA and LDA (sciki…
…t-learn#8130)

* for scikit-learn#7998

* Fix some style error and add test

* Add local variable store_covariance

* better deprecation

* fix bug

* Style check

* fix covariance_

* style check

* Update

* modify test

* Formating

* update

* Update

* Add whats_new.rst

* Revert "Add whats_new.rst"

This reverts commit 4e5977d.

* whats_new

* Update for FutureWarning

* Remove warning from the setter

* add fit in test

* drop back

* Quick fix

* Small fix

* Fix

* update new

* Fix space

* Fix docstring

* fix style

* Fix

* fix assert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment