Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradient boosting models ignore min_impurity_split parameter #8006

Closed
sebp opened this issue Dec 7, 2016 · 1 comment
Closed

Gradient boosting models ignore min_impurity_split parameter #8006

sebp opened this issue Dec 7, 2016 · 1 comment
Labels

Comments

@sebp
Copy link
Contributor

@sebp sebp commented Dec 7, 2016

Description

Gradient boosting models ignore min_impurity_split parameter introduced in commit 376aa50.

Expected Results

self.min_impurity_split should be passed to DecisionTreeRegressor in BaseGradientBoosting._fit_stage.

Actual Results

self.min_impurity_split is never read in BaseGradientBoosting or any of its sub-classes.

Versions

  • Linux-4.8.10-300.fc25.x86_64-x86_64-with-fedora-25-Twenty_Five
  • Python 3.5.2 |Continuum Analytics, Inc.| (default, Jul 2 2016, 17:53:06)
    [GCC 4.4.7 20120313 (Red Hat 4.4.7-1)]
  • NumPy 1.11.2
  • SciPy 0.18.1
  • Scikit-Learn @ 3dcb873
@amueller
Copy link
Member

@amueller amueller commented Dec 7, 2016

Thanks for the report. Do you want to submit a fix with regression test?

sebp pushed a commit to sebp/scikit-learn that referenced this issue Dec 10, 2016
self.min_impurity_split should be passed to
DecisionTreeRegressor in BaseGradientBoosting._fit_stage.

Fixes scikit-learn#8006
sebp pushed a commit to sebp/scikit-learn that referenced this issue Dec 11, 2016
self.min_impurity_split should be passed to
DecisionTreeRegressor in BaseGradientBoosting._fit_stage.

Fixes scikit-learn#8006
sebp pushed a commit to sebp/scikit-learn that referenced this issue Dec 13, 2016
self.min_impurity_split should be passed to
DecisionTreeRegressor in BaseGradientBoosting._fit_stage.

Fixes scikit-learn#8006
sebp pushed a commit to sebp/scikit-learn that referenced this issue Dec 13, 2016
self.min_impurity_split should be passed to
DecisionTreeRegressor in BaseGradientBoosting._fit_stage.

Fixes scikit-learn#8006
jnothman added a commit that referenced this issue Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.