New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG+1] Drop NumPy < 1.8 #8874
[MRG+1] Drop NumPy < 1.8 #8874
Conversation
7aa463b
to
8d27a7c
Compare
Skimming this PR this looks good overall. Could you keep the numpy-related stuff only in this PR? I feel the review process will be easier this way. |
I'll start looking at #8854 first, which does the scipy-related removal/deprecation, and then tackle this one. |
Yeah, I figured it might be easier to get #8854 in and then rebase - doing these in parallel would create some merge conflicts. |
60a0176
to
5ed68bc
Compare
9855d73
to
0434ea1
Compare
Rebased and ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes LGTM though I've not checked for completeness
I don't think this is resolved in flake8 yet: 80c1bf1 |
I am going to merge this one without waiting for AppVeyor. Thanks a lot @naoyak ! |
ref: #8810
mostly removing old backports from
utils.fixes