Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Make all non-canonical modules private? #9250
This is maybe for 1.0. Recently we started marking files like
from sklearn.model_selection import cross_val_score
For many (older?) models that's not the case, we have
from sklearn.linear_model.logistic import LogisticRegression from sklearn.linear_model import LogisticRegression
I am certain that there is code importing from the submodules, but deprecation is fine. we might need to pay attention to whether or not base class implementations get imported into the public modules…
On 30 Jun 2017 6:13 am, "Jacob Schreiber" ***@***.***> wrote: I would support this as it seems like it could clear up a lot of confusion. Do you believe there are any people directly trying to use the functions that would be made private? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#9250 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEz681uJKmev3Om4l4YDjvFQ9od_qqaks5sJAVxgaJpZM4OJW9F> .
Below is the list of the folders whose files need to be preceded by an underscore. The procedure is pretty straightforward:
(Note that this only addresses the folders. Files like
I had a ton of private datasets, such as names, text and geographical data. I used to use the following utils to download and manage these:
from sklearn.datasets.base import (get_data_home, RemoteFileMetadata, _fetch_remote)
What's the recommended approach now?
you can import
However, now you are aware that
This said, be aware that we are going to define a developer API which will define some backward support for these types of utilities used in third-party.