Join GitHub today
[MRG+1] correct comparison in GaussianNB for 'priors' #10005
What does this implement/fix? Explain your changes.
correct comparison in GaussianNB for 'priors'
Any other comments?
I am not fully sure if I have written the test as correctly since, I have written it as
what is the benefit of squashing commits at this stage? we squash when we merge, and until then it's good to have a record of what's changed since the last review, and to be able to follow links to commits.…
On 26 Oct 2017 4:22 pm, "Gaurav Dhingra" ***@***.***> wrote: I have addressed the comments and fixed the failing flake8 errors. Do I need to squash the commits? (I have 2 commits now) Was wondering if you follow some strict policy against 'squashing' public commits. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#10005 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEz6zvxy9ZPyCvLYVqvOOo7MIOC0XqUks5swBcXgaJpZM4QGh4g> .