Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[MRG+2] make_circles() now works with odd number of samples, test added #10045
Fixes #10037 and adds corresponding tests
What does this implement/fix? Explain your changes.
Fixes he faulty behaviour of
Any other comments?
you could add another test, but looks good either way.
@@ Coverage Diff @@ ## master #10045 +/- ## ========================================== + Coverage 96.19% 96.19% +<.01% ========================================== Files 336 336 Lines 62725 62743 +18 ========================================== + Hits 60336 60354 +18 Misses 2389 2389
LGTM except for something to confirm from core devs. Also wondering if it will be helpful to explicitly state that the center of the two circles is fixed to (0,0) and the radius of the outer circle is 1.
@christianbraune79 Could you please take some time to finish this, it's very close form merge.