Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+2] Neighborhood Components Analysis #10058

Merged
merged 89 commits into from Feb 28, 2019
Commits on Oct 27, 2017
  1. first commit

    wdevazelhes committed Oct 27, 2017
Commits on Nov 2, 2017
  1. remove comment

    wdevazelhes committed Oct 27, 2017
  2. remove useless None

    wdevazelhes committed Oct 31, 2017
  3. simplify tests

    wdevazelhes committed Oct 31, 2017
  4. ensure min samples = 2 to make check_fit2d_1sample pass

    wdevazelhes committed Nov 2, 2017
Commits on Nov 7, 2017
  1. Do not precompute pairwise differences

    wdevazelhes committed Nov 7, 2017
    Indeed, they do not add a significative speedup but have a high memory cost.
Commits on Nov 14, 2017
  1. add example

    wdevazelhes committed Nov 14, 2017
  2. reorganize transposes

    wdevazelhes committed Nov 14, 2017
  3. simplify gradient

    wdevazelhes committed Nov 14, 2017
Commits on Nov 22, 2017
  1. Fixes according to code review

    wdevazelhes committed Nov 22, 2017
Commits on Jan 3, 2018
  1. Adapt documentation to Neighborhood Components Analysis

    wdevazelhes committed Dec 29, 2017
  2. fix pep8 errors

    wdevazelhes committed Jan 3, 2018
  3. fix flake8 error

    wdevazelhes committed Jan 3, 2018
  4. fix encoding error

    wdevazelhes committed Jan 3, 2018
Commits on Jan 15, 2018
  1. changes according to review #10058 (review)

    wdevazelhes committed Jan 15, 2018
  2. correct objective function doc

    wdevazelhes committed Jan 15, 2018
Commits on May 28, 2018
Commits on Jun 5, 2018
  1. Update documentation.

    wdevazelhes committed Jun 5, 2018
  2. Merge branch 'master' into nca

    wdevazelhes committed Jun 5, 2018
Commits on Jun 6, 2018
  1. FIX: import scipy.misc.logsumexp for older versions of scipy, and sci…

    wdevazelhes committed Jun 6, 2018
    …py.special.logsumexp otherwise
Commits on Jun 7, 2018
  1. FIX: remove newly introduced keepdims for logsumexp

    wdevazelhes committed Jun 7, 2018
  2. FIX: remove unused old masks and use the new mask instead

    wdevazelhes committed Jun 7, 2018
Commits on Jun 20, 2018
  1. FIX: fix doctest CI fail by putting ellipsis

    wdevazelhes committed Jun 20, 2018
Commits on Jun 22, 2018
  1. Updates to be coherent with latest changes from pr #8602 (commits 7af…

    wdevazelhes committed Jun 22, 2018
    …a6bb and 7e68321)
    
    - Rename n_features_out to n_components
    - Rename transformation_ to components_
    - Update tests with assert_raise_message
    - Improve verbosity
  2. Merge branch 'nca_feat/comments_changes' into nca

    wdevazelhes committed Jun 22, 2018
  3. ENH: Add warm_start feature from LMNN (PR #8602)

    wdevazelhes committed Jun 22, 2018
  4. FIX: rename remaining old n_features_out to n_components

    wdevazelhes committed Jun 22, 2018
  5. FIX: Update doc like in commit 7afa6bb

    wdevazelhes committed Jun 22, 2018
  6. FIX: make test_warm_start_effectiveness_work

    wdevazelhes committed Jun 22, 2018
    - Fix if to elif (otherwise warm_start does not work)
    - Use iris dataset because it (empirically) makes a more significative difference between warm start and cold start NCA
    - Use the default max_iter (50 at time of writing) instead of 10 to make NCA converge more
    - Augment comparison threshold from 2 to 3 because in this case differences are a bit bigger
  7. ENH: Add possible LDA initialization

    wdevazelhes committed Jun 22, 2018
Commits on Jun 25, 2018
  1. ENH: add 'auto' initialization

    wdevazelhes committed Jun 25, 2018
    - Change nca code + docstrings
    - Make test
    - Update illustration example because axes scale should be the same to better see euclidean distances (the example with updated code (lda initialization) makes data more stretched hence we see more the problem
  2. Merge branch 'master' into nca

    wdevazelhes committed Jun 25, 2018
  3. FIX test appropriate message depending on init

    wdevazelhes committed Jun 25, 2018
  4. FIX import name with relative path

    wdevazelhes committed Jun 25, 2018
Commits on Jun 26, 2018
  1. FIX Move LDA import inside NCA class to avoid circular dependencies

    wdevazelhes committed Jun 26, 2018
    LDA was importing at one point neighbors hence NCA
Commits on Jun 28, 2018
  1. DOC add what s new entry

    wdevazelhes committed Jun 28, 2018
Commits on Jun 29, 2018
  1. MAINT simplify gradient testing

    wdevazelhes committed Jun 29, 2018
  2. TST FIX be more tolerant on decimals for older versions of numerical …

    wdevazelhes committed Jun 29, 2018
    …packages
  3. STY fix continuation lines, removing backslashes

    wdevazelhes committed Jun 29, 2018
Commits on Jul 15, 2018
  1. FIX: fix logsumexp import

    wdevazelhes committed Jul 15, 2018
Commits on Jul 23, 2018
  1. TST: simplify verbose testing with pytest capsys

    wdevazelhes committed Jul 23, 2018
  2. Merge branch 'master' into nca

    wdevazelhes committed Jul 23, 2018
    # Conflicts:
    #	doc/whats_new/v0.20.rst
Commits on Aug 1, 2018
  1. TST: check more explicitely verbose

    wdevazelhes committed Aug 1, 2018
  2. FIX: remove non-ASCII character

    wdevazelhes committed Aug 1, 2018
Commits on Aug 17, 2018
  1. ENH: simplify gradient expression

    wdevazelhes committed Aug 17, 2018
Commits on Nov 29, 2018
  1. MAINT: address review #10058 (review)

    wdevazelhes committed Nov 29, 2018
  2. Merge branch 'master' into nca

    wdevazelhes committed Nov 29, 2018
    # Conflicts:
    #	doc/whats_new/v0.20.rst
    #	sklearn/neighbors/__init__.py
  3. DOC: Add what's new entry

    wdevazelhes committed Nov 29, 2018
Commits on Dec 6, 2018
  1. Merge branch 'master' into nca

    wdevazelhes committed Dec 6, 2018
  2. FIX: try the exact syntax that passed the linter

    wdevazelhes committed Dec 6, 2018
  3. TST: give some tolerance for test_toy_example_collapse_points

    wdevazelhes committed Dec 6, 2018
Commits on Dec 7, 2018
  1. relaunch travis

    wdevazelhes committed Dec 7, 2018
Commits on Dec 12, 2018
  1. FIX: use checked_random_state instead of np.random

    wdevazelhes committed Dec 12, 2018
  2. FIX: delete iterate.dat

    wdevazelhes committed Dec 12, 2018
  3. Merge branch 'master' into nca

    wdevazelhes committed Dec 12, 2018
  4. FIX: Fix dealing with the case of LinearDiscriminantAnalysis initiali…

    wdevazelhes committed Dec 12, 2018
    …zation:
    
    - fixed when to choose LinearDisciminantAnalysis when given 'auto' initialization
    - adapted the tests where 'lda' init can be set so that this cases will not return an error
Commits on Jan 18, 2019
  1. Address reviews #10058 (review) and #10058 (review)

    wdevazelhes committed Jan 18, 2019
  2. STY: fix PEP8 line too long error

    wdevazelhes committed Jan 18, 2019
  3. Fix doctest

    wdevazelhes committed Jan 18, 2019
Commits on Jan 22, 2019
  1. FIX: remove deprecated assert_true

    wdevazelhes committed Jan 22, 2019
  2. TST fix assertion always true in tests

    wdevazelhes committed Jan 22, 2019
  3. TST: fix PEP8 indent error

    wdevazelhes committed Jan 22, 2019
  4. Merge branch 'master' into nca

    wdevazelhes committed Jan 22, 2019
Commits on Feb 25, 2019
  1. Merge branch 'master' into nca

    wdevazelhes committed Feb 25, 2019
    # Conflicts:
    #	doc/whats_new/v0.21.rst
  2. STY: fix pep8 errors

    wdevazelhes committed Feb 25, 2019
Commits on Feb 26, 2019
  1. adress gael's review except #10058 (review)

    wdevazelhes committed Feb 26, 2019
  2. Address aurelien's review

    wdevazelhes committed Feb 26, 2019
  3. Simplify test about auto init even more

    wdevazelhes committed Feb 26, 2019
  4. Fix doc and replace embedding by projection for consistency

    wdevazelhes committed Feb 26, 2019
  5. Address Gael's review

    wdevazelhes committed Feb 26, 2019
Commits on Feb 27, 2019
  1. few nitpicks and make some links in the doc work

    wdevazelhes committed Feb 27, 2019
  2. Address alex's review

    wdevazelhes committed Feb 27, 2019
Commits on Feb 28, 2019
  1. Adress Alex's review

    wdevazelhes committed Feb 28, 2019
  2. Add authors in test too

    wdevazelhes committed Feb 28, 2019
  3. add check_scalar to utils

    wdevazelhes committed Feb 28, 2019
  4. MajorFeature > API

    jnothman committed Feb 28, 2019
You can’t perform that action at this time.