Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[MRG+1] Fix omp non normalize #10071
there was no open issue. I fixed directly. Basically OMP was returning
What does this implement/fix? Explain your changes.
Any other comments?
thanks @josephsalmon for pointing me the bug.
I don't know OMP or the linalg well, but from a non-expert perspective, this looks well-justified and tested. LGTM
@@ Coverage Diff @@ ## master #10071 +/- ## ========================================== + Coverage 96.19% 96.19% +<.01% ========================================== Files 336 336 Lines 62739 62749 +10 ========================================== + Hits 60353 60363 +10 Misses 2386 2386