New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG + 1] adding sample weights for BayesianRidge #10112

Merged
merged 2 commits into from Nov 13, 2017

Conversation

Projects
None yet
5 participants
@pstjohn
Contributor

pstjohn commented Nov 11, 2017

This is a first stab at adding sample_weight as a kwarg to BayesianRidge.
Seems to work well, and matches the Ridge.fit() method.

fixes #10111

@agramfort

This comment has been minimized.

Show comment
Hide comment
@agramfort

agramfort Nov 12, 2017

Member

please update what's new

Member

agramfort commented Nov 12, 2017

please update what's new

@jmschrei

This comment has been minimized.

Show comment
Hide comment
@jmschrei

jmschrei Nov 12, 2017

Member

Looks fairly straightforward to me as well. Thanks for the contribution!

Member

jmschrei commented Nov 12, 2017

Looks fairly straightforward to me as well. Thanks for the contribution!

@jnothman

This comment has been minimized.

Show comment
Hide comment
@jnothman

jnothman Nov 12, 2017

Member

Please add an entry to the change log at doc/whats_new/v0.20.rst. Like the other entries there, please reference thus pull request with :issue: and credit yourself (and other contributors if applicable) with :user:

Member

jnothman commented Nov 12, 2017

Please add an entry to the change log at doc/whats_new/v0.20.rst. Like the other entries there, please reference thus pull request with :issue: and credit yourself (and other contributors if applicable) with :user:

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Nov 13, 2017

Codecov Report

Merging #10112 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10112      +/-   ##
==========================================
+ Coverage    96.2%    96.2%   +<.01%     
==========================================
  Files         337      337              
  Lines       62817    62827      +10     
==========================================
+ Hits        60432    60442      +10     
  Misses       2385     2385
Impacted Files Coverage Δ
sklearn/linear_model/tests/test_bayes.py 90.42% <100%> (+0.89%) ⬆️
sklearn/linear_model/bayes.py 95.45% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bead39...44f025a. Read the comment docs.

codecov bot commented Nov 13, 2017

Codecov Report

Merging #10112 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10112      +/-   ##
==========================================
+ Coverage    96.2%    96.2%   +<.01%     
==========================================
  Files         337      337              
  Lines       62817    62827      +10     
==========================================
+ Hits        60432    60442      +10     
  Misses       2385     2385
Impacted Files Coverage Δ
sklearn/linear_model/tests/test_bayes.py 90.42% <100%> (+0.89%) ⬆️
sklearn/linear_model/bayes.py 95.45% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bead39...44f025a. Read the comment docs.

@pstjohn

This comment has been minimized.

Show comment
Hide comment
@pstjohn

pstjohn Nov 13, 2017

Contributor

Thanks for the pointers on what's new!

Contributor

pstjohn commented Nov 13, 2017

Thanks for the pointers on what's new!

@glemaitre glemaitre changed the title from adding sample weights for BayesianRidge (fix #10111) to [MRG + 1] adding sample weights for BayesianRidge (fix #10111) Nov 13, 2017

@glemaitre

This comment has been minimized.

Show comment
Hide comment
@glemaitre

glemaitre Nov 13, 2017

Contributor

LGTM

Contributor

glemaitre commented Nov 13, 2017

LGTM

@glemaitre glemaitre changed the title from [MRG + 1] adding sample weights for BayesianRidge (fix #10111) to [MRG + 1] adding sample weights for BayesianRidge Nov 13, 2017

@jnothman jnothman merged commit c24a13e into scikit-learn:master Nov 13, 2017

6 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 96.2%)
Details
codecov/project 96.2% (+<.01%) compared to 4bead39
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
lgtm analysis: Python No alert changes
Details
@jnothman

This comment has been minimized.

Show comment
Hide comment
@jnothman

jnothman Nov 13, 2017

Member

Thanks

Member

jnothman commented Nov 13, 2017

Thanks

maskani-moh added a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017

jwjohnson314 pushed a commit to jwjohnson314/scikit-learn that referenced this pull request Dec 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment