Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[MRG+2] discrete branch: add an example for KBinsDiscretizer #10192
Do we need to merge master into discrete again?
Done, Circle is not failing anymore.
ping @jnothman I think it's ready for review. Thanks :)
ping @amueller The example is based on your book "Introduction to machine learning with python" (Chapter 4 section 2 binning&discretization) using scikit-learn's latest api KBinsDiscretizer. Would be grateful if you can take some time to have a look (I've put your name at the beginning). Thanks :)
referenced this pull request
Nov 23, 2017
@jnothman Thanks :) Comments addressed.
In fact, the value of n_bins here (10) is among the best choices from cv (if we gridsearch on a pipeline KBinsDiscretizer + LinearRegression). So I think put the value directly is consistant with this statement and might make the example easier to go through. Especially considering that we now have another example which shows the detailed tuning process.
I don't find plt.sca under examples folder. I have followed matplotlib example and use a more common way.