MRG Sparse rfe #1029

Closed
wants to merge 7 commits into
from

Conversation

Projects
None yet
3 participants
@amueller
Member

amueller commented Aug 15, 2012

This adds sparse matrix support to RFE and RFCE.

I started using a np.where(boolean_mask)[0] pattern quite a lot for indexing into sparse matrices.
Is that ok? Is it better to do np.arange(len(mask))[mask] or something like that?

This PR depends on #1025 which should be merged first. So this PR actually only adds a single commit.

Closes issue #1018.

@agramfort

This comment has been minimized.

Show comment
Hide comment
@agramfort

agramfort Aug 16, 2012

Member

looks good/clean to me

Member

agramfort commented Aug 16, 2012

looks good/clean to me

@mblondel

This comment has been minimized.

Show comment
Hide comment
@mblondel

mblondel Aug 16, 2012

Member

Indeed, good job!

Member

mblondel commented Aug 16, 2012

Indeed, good job!

@amueller

This comment has been minimized.

Show comment
Hide comment
@amueller

amueller Aug 16, 2012

Member

Thanks you two :)
@mblondel could you please have a look at #1025. Then I can merge those two later on.

Member

amueller commented Aug 16, 2012

Thanks you two :)
@mblondel could you please have a look at #1025. Then I can merge those two later on.

@amueller

This comment has been minimized.

Show comment
Hide comment
@amueller

amueller Aug 16, 2012

Member

Merged by rebase. Thanks for the feedback!

Member

amueller commented Aug 16, 2012

Merged by rebase. Thanks for the feedback!

@amueller amueller closed this Aug 16, 2012

@amueller amueller referenced this pull request Aug 17, 2012

Closed

RFE on sparse data #1018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment