New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Fixes #10571: Shape of `coef_` wrong for linear_model.Lasso when using `fit_interce… #10687

Merged
merged 5 commits into from Feb 27, 2018

Conversation

Projects
None yet
3 participants
@martin-hahn
Contributor

martin-hahn commented Feb 24, 2018

Reference Issues/PRs

Fixes #10571
Resolves #10616
Shape of coef_ wrong for linear_model.Lasso when using fit_intercept=False

What does this implement/fix? Explain your changes.

np.squeeze was misused and returned zero shaped arrays.

@martin-hahn

This comment has been minimized.

Contributor

martin-hahn commented Feb 24, 2018

I think the failure on circleci is a false positive alarm. Perhaps someone with permissions can rerun it.

@jnothman

LGTM

@jnothman

LGTM

@jnothman jnothman changed the title from [MRG] Fixes #10571: Shape of `coef_` wrong for linear_model.Lasso when using `fit_interce… to [MRG+1] Fixes #10571: Shape of `coef_` wrong for linear_model.Lasso when using `fit_interce… Feb 25, 2018

@jnothman

This comment has been minimized.

Member

jnothman commented Feb 25, 2018

Please add an entry to the change log at doc/whats_new/v0.20.rst. Like the other entries there, please reference this pull request with :issue: and credit yourself (and other contributors if applicable) with :user:

@jnothman

This comment has been minimized.

Member

jnothman commented Feb 25, 2018

Although there's another PR at #10616

martin-hahn and others added some commits Feb 24, 2018

@jnothman jnothman merged commit da71b82 into scikit-learn:master Feb 27, 2018

8 checks passed

ci/circleci: deploy Your tests passed on CircleCI!
Details
ci/circleci: python2 Your tests passed on CircleCI!
Details
ci/circleci: python3 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 94.98%)
Details
codecov/project Absolute coverage decreased by -0.01% but relative coverage increased by +5.01% compared to 69e9111
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
lgtm analysis: Python No alert changes
Details
@jnothman

This comment has been minimized.

Member

jnothman commented Feb 27, 2018

Thanks @martin-hahn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment