New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1]: Fixing Typos #11017

Merged
merged 8 commits into from Apr 23, 2018

Conversation

Projects
None yet
5 participants
@nnadeau
Contributor

nnadeau commented Apr 23, 2018

Reference Issues/PRs

  • None

What does this implement/fix? Explain your changes.

Any other comments?

  • Thanks for all the hard work!
@@ -4,7 +4,7 @@
ENGLISH_STOP_WORDS = frozenset([
"a", "about", "above", "across", "after", "afterwards", "again", "against",
"all", "almost", "alone", "along", "already", "also", "although", "always",
"am", "among", "amongst", "amoungst", "amount", "an", "and", "another",
"am", "among", "amongst", "amongst", "amount", "an", "and", "another",

This comment has been minimized.

@glemaitre

glemaitre Apr 23, 2018

Contributor

not this one

Nicholas Nadeau
@nnadeau

This comment has been minimized.

Contributor

nnadeau commented Apr 23, 2018

@glemaitre reverted in 16c4093

@nnadeau nnadeau changed the title from [WIP]: Fixing Typos to [MRG]: Fixing Typos Apr 23, 2018

@rth

rth approved these changes Apr 23, 2018

This is helpful, thank you!

@rth rth changed the title from [MRG]: Fixing Typos to [MRG+1]: Fixing Typos Apr 23, 2018

@jnothman jnothman merged commit 3e26fc6 into scikit-learn:master Apr 23, 2018

8 checks passed

ci/circleci: deploy Your tests passed on CircleCI!
Details
ci/circleci: python2 Your tests passed on CircleCI!
Details
ci/circleci: python3 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 95.11%)
Details
codecov/project 95.12% (+<.01%) compared to 9ea723f
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
lgtm analysis: Python No alert changes
Details

@nnadeau nnadeau deleted the nnadeau:typos branch Apr 24, 2018

@amueller

This comment has been minimized.

Member

amueller commented Apr 24, 2018

thanks. It's always surprising how quickly these creep in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment