Join GitHub today
API: Adds transformer support in ColumnTransformer.remainder #11315
I updated this PR with an implementation where
In master, 'remainder' is already not allowed as a transformer name:
I don't think there's any problem changing this as long as ColumnTransformer has not yet been released. If we can get this patch into the upcoming release, I'd much prefer the simplicity of appending the remainder transformer/passthrough to
referenced this pull request
Jun 21, 2018
Rather than add a param to
_iter, I'd personally prefer
_validate_names(zip(*self.transformers)) and not using
_iter to validate names. But I can see why the current version might also be construed as clearer.
Do you have a test case where you check the value of
transformers_[-1]? Do you have a test case where there are no remaining columns?
Do you think that if there are no remaining columns but a remainder transformer is given, we should raise a warning?
For the case where there is no remaining columns and a remainder estimator, I do not think there needs to be a warning. A warning would have to direct a user to a preferred usage option. In our case it would either be to change
Thanks a lot for this PR!
Really nice PR, only added a bunch of minor comments.