Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Added docstring checks for feature_selection, kernel_approximation and neighbors modules #11421

Conversation

@NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented Jul 3, 2018

Reference Issues/PRs

Fixes parts of #9325

What does this implement/fix? Explain your changes.

Any other comments?

As ProjectionToHashMixin and GaussianRandomProjectionHash are already under-documented and it was proposed to make them private (#8029), I only did the bare minimum for the tests to pass.

…d neighbors modules
@agramfort agramfort changed the title Added docstring checks for feature_selection, kernel_approximation and neighbors modules [WIP] Added docstring checks for feature_selection, kernel_approximation and neighbors modules Jul 4, 2018
Copy link
Member

@jnothman jnothman left a comment

You've alerted me to the fact that we convert sparse matrix formats here. I think we should be allowing csr or csc in fit, and perhaps even prefer csc in prediction... Open another issue?

@NicolasHug NicolasHug changed the title [WIP] Added docstring checks for feature_selection, kernel_approximation and neighbors modules [MRG] Added docstring checks for feature_selection, kernel_approximation and neighbors modules Jul 8, 2018
@NicolasHug
Copy link
Member Author

@NicolasHug NicolasHug commented Jul 8, 2018

Sorry, I'm not sure exactly what the new issue should be about?

@GaelVaroquaux
Copy link
Member

@GaelVaroquaux GaelVaroquaux commented Jul 18, 2018

Merge conflicts.

@jnothman jnothman merged commit 813d7de into scikit-learn:master Jul 19, 2018
7 checks passed
7 checks passed
ci/circleci: deploy Your tests passed on CircleCI!
Details
ci/circleci: python2 Your tests passed on CircleCI!
Details
ci/circleci: python3 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 5140762...27625cf
Details
codecov/project 95.29% remains the same compared to 5140762
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@NicolasHug NicolasHug deleted the NicolasHug:docstring_checks_featureselection_kernelappr_neighbors branch Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.