Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+2] change tol in test ridge #11587

Merged

Conversation

@sergulaydore
Copy link
Contributor

@sergulaydore sergulaydore commented Jul 17, 2018

Reference Issues/PRs

Fixes #11200 (Instability in test_ridge.py::test_ridge_sample_weights ). The test was failing for some random states. We observed 26 failures for 100 runs.

What does this implement/fix? Explain your changes.

The problem was that the default tolerance in Ridge was 1e-3 and assert_almost_equal uses a tolerance of 1e-6. Adding tol=1e-6 to Ridge fixes the issue.

Any other comments?

The run time takes approximately 1.3 times of previous.
See more details at #11200 (comment)

TomDLT
TomDLT approved these changes Jul 17, 2018
Copy link
Member

@TomDLT TomDLT left a comment

LGTM, thanks !

Loading

@agramfort agramfort changed the title change tol in test ridge [MRG+2] change tol in test ridge Jul 17, 2018
@GaelVaroquaux
Copy link
Member

@GaelVaroquaux GaelVaroquaux commented Jul 17, 2018

Something weird is happening in appveyor. Does someone understand?

I think that I'll still merge.

Loading

@GaelVaroquaux
Copy link
Member

@GaelVaroquaux GaelVaroquaux commented Jul 17, 2018

OK, merging!

Loading

@GaelVaroquaux GaelVaroquaux merged commit a496491 into scikit-learn:master Jul 17, 2018
4 of 5 checks passed
Loading
@sergulaydore sergulaydore deleted the instability_in_test_rigde branch Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants