[MRG+2] Change default of ColumnTransformer remainder from passthrough to drop #11603
Conversation
jorisvandenbossche
changed the title
|
Travis is passing except of the sag failing one |
|
I'm sorry, but I don't think that it's a good idea to merge with the failing SAG. The risk is to end up with a failing test in master, which isn't a good situation, in particular for a sprint. |
GaelVaroquaux
changed the title
|
I've restarted the failing travis job, hoping that it will go away. |
|
@GaelVaroquaux It's a random failure that is already happening on master as well (I think Guillaume is working on a fix #11606) |
|
OK. However, we just got a very different error, that does not seem random to me: |
|
Ah, now it is another one (collection of the test), and that is just fixed in master normally, restarting again. |
…-change-remainder-default
|
Merged master in the hope this will then be green |
…-change-remainder-default
…-change-remainder-default
|
Everything is passing aside from appveyor that is pending. I'll merge! |
jorisvandenbossche
deleted the
columntransformer-change-remainder-default
branch
Follow-up on #9012
The motivation is that silently passing through uniquely identifying columns (e.g. a user id) or the target will lead to catastrophic overfitting that beginner users will have a hard time to debug.