[MRG] Fixed whatsnew and tiny docstring fix #12669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test coverage increased
tests cleaned using pytest parametrize
improved docstring for fit_grid_point
eamanu
reviewed
Nov 26, 2018
doc/whats_new/v0.21.rst
Outdated
| methods :func:`cross_val_score`, :func:`cross_val_predict`, | ||
| :func:`cross_validate`, now print train scores when `return_train_scores` is | ||
| True and `verbose` > 2. For :func:`learning_curve`, and :func:`validation_curve` | ||
| only the latter is required. |
|
The test failure is very suspicious. https://travis-ci.org/scikit-learn/scikit-learn/jobs/459951142 |
|
oh it's #12674 nevermind |
jeremiedbb
reviewed
Nov 26, 2018
doc/whats_new/v0.21.rst
Outdated
| methods :func:`cross_val_score`, :func:`cross_val_predict`, | ||
| :func:`cross_validate`, now print train scores when `return_train_scores` is | ||
| True and `verbose` > 2. For :func:`learning_curve`, and :func:`validation_curve` | ||
| only the latter is required. |
There was a problem hiding this comment.
The indentation isn't right. Please keep the same indent as others entries.
There was a problem hiding this comment.
thanks for the comment, corrected
jeremiedbb
approved these changes
Nov 26, 2018
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This reverts commit 58d9ed3.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This reverts commit 58d9ed3.
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
As mentioned in PR #12613 , what's new cannot reference private API, so fixing this
Also, while documenting found that fit_grid_point always fits only test, so changed the return part of the docstring