Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Fixed whatsnew and tiny docstring fix #12669

Merged
merged 14 commits into from Nov 27, 2018

Conversation

@marctorrellas
Copy link
Contributor

commented Nov 25, 2018

Reference Issues/PRs

As mentioned in PR #12613 , what's new cannot reference private API, so fixing this

Also, while documenting found that fit_grid_point always fits only test, so changed the return part of the docstring

marctorrellas added 12 commits Nov 18, 2018
print train score if return_train_score
test coverage increased
added test for multimetric;
tests cleaned using pytest parametrize
whats_new without reference to private API;
improved docstring for fit_grid_point
methods :func:`cross_val_score`, :func:`cross_val_predict`,
:func:`cross_validate`, now print train scores when `return_train_scores` is
True and `verbose` > 2. For :func:`learning_curve`, and :func:`validation_curve`
only the latter is required.

This comment has been minimized.

Copy link
@eamanu

eamanu Nov 26, 2018

Contributor

There is a whitespace

This comment has been minimized.

Copy link
@marctorrellas

marctorrellas Nov 26, 2018

Author Contributor

is it ok now?

@amueller

This comment has been minimized.

Copy link
Member

commented Nov 26, 2018

@amueller

This comment has been minimized.

Copy link
Member

commented Nov 26, 2018

oh it's #12674 nevermind

methods :func:`cross_val_score`, :func:`cross_val_predict`,
:func:`cross_validate`, now print train scores when `return_train_scores` is
True and `verbose` > 2. For :func:`learning_curve`, and :func:`validation_curve`
only the latter is required.

This comment has been minimized.

Copy link
@jeremiedbb

jeremiedbb Nov 26, 2018

Member

The indentation isn't right. Please keep the same indent as others entries.

This comment has been minimized.

Copy link
@marctorrellas

marctorrellas Nov 26, 2018

Author Contributor

thanks for the comment, corrected

@eamanu
eamanu approved these changes Nov 26, 2018
Copy link
Contributor

left a comment

LGTM. Like say @amueller, your CI fail for #12674

@jnothman
Copy link
Member

left a comment

Okay :)

@jnothman jnothman merged commit c49a5bf into scikit-learn:master Nov 27, 2018

8 of 9 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
LGTM analysis: C/C++ No code changes detected
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No alert changes
Details
ci/circleci: deploy Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: python2 Your tests passed on CircleCI!
Details
ci/circleci: python3 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
xhlulu added a commit to xhlulu/scikit-learn that referenced this pull request Apr 28, 2019
xhlulu added a commit to xhlulu/scikit-learn that referenced this pull request Apr 28, 2019
xhlulu added a commit to xhlulu/scikit-learn that referenced this pull request Apr 28, 2019
koenvandevelde added a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.